[CQT-478] Correct the matrix representation of SqrtSWAP - #713
Merged
Merged
Conversation
elenbaasc
reviewed
Sep 15, 2026
elenbaasc
left a comment
elenbaasc
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for making the changes!
Just a few minor comments 🙂
Contributor
Author
|
Thanks Chris, all three done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the SqrtSWAP matrix to match the updated cQASM spec. InvSqrtSWAP already matched and is unchanged.
Added tests for the identities the gate names imply, SqrtSWAP² = SWAP, the two gates being inverses, plus the same checks for SqrtISWAP, CV and DCNOT.