[CQT-466] Increase test coverage - #709
Open
rares1609 wants to merge 2 commits into
Open
Conversation
elenbaasc
changed the title
elenbaasc
reviewed
Sep 9, 2026
Comment on lines
+113
to
+115
| def test_eq_only_one_has_rotations(self, semantic_with_rotations: CanonicalGateSemantic) -> None: | ||
| assert semantic_with_rotations != CanonicalGateSemantic((0.25, 0.25, 0.25)) | ||
| assert CanonicalGateSemantic((0.25, 0.25, 0.25)) != semantic_with_rotations |
Collaborator
There was a problem hiding this comment.
I don't understand the point of these asserts?
Comment on lines
+107
to
+108
| def test_eq_different_type(self) -> None: | ||
| assert IR() != "not an IR" |
Collaborator
There was a problem hiding this comment.
This is too obvious to be a test.
Comment on lines
+110
to
+111
| def test_repr(self) -> None: | ||
| assert repr(IR()) == "IR: []" |
Collaborator
There was a problem hiding this comment.
Would be more interesting (better test), to add some statements. This will force one to make sure to define a __repr__ method for each statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.