Decribe how to choose input notes for the Action containing the Desired Asset - #136
Open
vivek-arte wants to merge 2 commits into
Open
Decribe how to choose input notes for the Action containing the Desired Asset#136vivek-arte wants to merge 2 commits into
vivek-arte wants to merge 2 commits into
Conversation
…taining the Desired Asset
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PaulLaux
reviewed
Aug 24, 2026
| ----------------------------------------------- | ||
|
|
||
| In the Action for the Desired Asset, the party creating the Swap Order can use any Note they possess of that AssetBase, with the `split\_flag` set, as the spend for that Action. | ||
| If the party does not have a Note of that Asset, they should use the Reference Note for that Asset, with the `split\_flag` set. |
There was a problem hiding this comment.
Ref notes guaranteed to have value = 0.
So the semantic should be "they should use any familiar note with the same asset base or a publicly known ref note - both with split_flag set (for uniformity).
(unify the two sentences into one OR statement)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The party creating the Swap Order can use any note they have of the Desired Asset. Alternatively, they can use the reference note that is available on the blockchain.
This PR includes this information in the specification.