Sync zcash v5.2.0 ci fix - #168
Merged
Merged
Conversation
The setup-rust-toolchain action exports RUSTFLAGS, which replaces the rustflags in .cargo/config.toml instead of adding to them. Only tests-unit.yml passed the cfgs back in, so the lint, test-crates and coverage jobs were building, linting and measuring a tree with every `all(zcash_unstable = "nu7", feature = "tx_v6")` block compiled out. Define the cfgs once per workflow as ZEBRA_CFGS and mirror them into each job that compiles code, including the two steps that set RUSTFLAGS/RUSTDOCFLAGS directly and so beat the action's export. Jobs that never evaluate cfgs are left alone: fmt, no-test-deps, deny, vet, and the cargo tree crates matrix. benchmarks.yml is also left alone, since changing what it measures would break the continuity of the series it publishes to gh-pages.
Turning the cfgs on left ci-basic as the only job building without them, and it has no toolchain pin, so nothing checked the MSRV build upstream compiles. Matrix the job instead: the legs run in parallel, so this costs no extra wall clock.
dmidem
marked this pull request as ready for review
September 7, 2026 09:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZEBRA_CFGS, and mirror them into everyjob that compiles code, including the two steps that set
RUSTFLAGS/RUSTDOCFLAGSdirectly and so beat the action's export.lint.yml:msrvovernu7: [true, false]. Turning the cfgs on leftci-basicas the only job building without them, and it has no toolchain pin,so nothing checked the MSRV build upstream compiles. The legs run in parallel,
so this costs no extra wall clock.
Jobs that never evaluate cfgs are untouched:
fmt,no-test-deps,deny,vet, and thecargo treecrates matrix.benchmarks.ymlandbook.ymlarealso untouched — changing what
benchmarks.ymlmeasures would break thecontinuity of the series it publishes to gh-pages.