Bump CURRENT_NETWORK_PROTOCOL_VERSION to 170_150 for NU7 - #162
Open
0xpierre-dev wants to merge 2 commits into
Open
Bump CURRENT_NETWORK_PROTOCOL_VERSION to 170_150 for NU7#1620xpierre-dev wants to merge 2 commits into
0xpierre-dev wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a single-node regtest started from
testnet-single-node-deploy/dockerfile(tested at
zsa-integration-demo@2b036fd; the same code is present onzsa1), zebrad aborts about ten seconds after the block at the NU7activation height (height 1 with the shipped config) is accepted:
Cause:
zebra-network/src/constants.rsshipsCURRENT_NETWORK_PROTOCOL_VERSION = Version(170_140), whilemin_specified_for_upgraderequires170_150for(Testnet(regtest), Nu7)(
types.rsline 119). Once the tip reaches activation, the peer set'schain-tip watcher calls
Version::min_remote_for_heightand the assertaborts zebrad. With the shipped
[state] ephemeral = true, the restartwipes the chain back to genesis, so a client that saw its block accepted
then fails in confusing ways (template height regresses; a reissuance forks
a fresh chain and fails contextual validation, e.g.
MissingReferenceNoteOnFirstIssuance).Repro: build and run the regtest image per the tx_tool README, mine one
block via
getblocktemplate/submitblock, watch the logs for ~10 seconds.The bundled test scenarios can complete inside that window, which may be
why CI does not catch it.
Fix: this PR bumps the constant to the NU7 Testnet value already
present as a comment in the file.
Verified locally: with this change the node survives sustained
mining/submission sessions on regtest — the same client integration suite
that deterministically failed on the unpatched image (template height
regression +
MissingReferenceNoteOnFirstIssuance) passes 5/5 on thepatched one, across issuance, reissuance, transfer, burn and finalization
flows.