Zsa1 diff, for reference only - #7

Draft

PaulLaux wants to merge 323 commits into

mainfrom

This pull request is big! We're only showing the most recent 250 commits

Commits on May 9, 2024

Fix comments, indroduce and use MatadataIdx type in the builder
dmidem
committed
50c6310
Update to upstream (zcash/main v0.8.0) (#103)
dmidem
authored
78c8efc

Commits on Jul 16, 2024

OrchardZSA backward compatability 0.8.0 (#104)

authored
39b479e

Commits on Jul 31, 2024

Synchronize Orchard with updates from zcash_note_encryption for zcash PR #2 issues resolve (#111)
dmidem
authored
6e6112c

Commits on Aug 14, 2024

Update ShieldedOutput implementation to return reference from enc_ciphertext (#112)
dmidem
authored
07b3697

Commits on Sep 19, 2024

Remove redundancy in vanilla/zsa circuits
ConstanceBeguier
authored
3ba9e5b

Commits on Oct 8, 2024

Updating test vectors (#114)
vivek-arte
authored
e2fb49d

Commits on Oct 10, 2024

Remove ZSA dummy notes
ConstanceBeguier
authored
dd69425

Commits on Oct 14, 2024

Changing the type of the asset description from String to Vec<u8> (#113)

vivek-arte
and
PaulLaux
authored
410037d

Commits on Oct 15, 2024

Provide compatibility with librustzcash/zcash_client_backend: derive Clone for CompactAction (#118)
dmidem
authored
a7c02d2

Commits on Nov 13, 2024

Exclude non-native assets from value_balance (#120)
alexeykoren
authored
25020f8

Commits on Nov 28, 2024

Simplify Unproven struct
ConstanceBeguier
authored
8a2a8de

Commits on Dec 9, 2024

Update SIGHASH according to OrchardDomain
ConstanceBeguier
authored
adc6995

Commits on Dec 12, 2024

Add Clone trait to auth-related structures (#125)
alexeykoren
authored
97cf5a3

Commits on Dec 16, 2024

Unify unique AssetBase concept in IssueAction
ConstanceBeguier
authored
8b89888

Commits on Dec 17, 2024

Add a reference note for each first issuance
ConstanceBeguier
authored
fe15076

Commits on Dec 20, 2024

Simplify bundle build function return type (#129)
ConstanceBeguier
authored
9eb97f0

Commits on Dec 25, 2024

Fix some links and typo (#127)
ConstanceBeguier
authored
3d2515b

Commits on Jan 6, 2025

Install libfontconfig1-dev to fix CI build on updated Ubuntu runner (#132)
dmidem
authored
0d2f439

Commits on Jan 8, 2025

Update AssetSuply and SupplyInfo (new) (#133)

authored
69f92a3

Commits on Jan 18, 2025

Update to orchard_auth_digest computation (#134)
vivek-arte
authored
3dbdbc5

Commits on Jan 23, 2025

[book] Update book with ZSA changes
ConstanceBeguier
authored
70daf8b
Update derivation of the rho value in Issue Notes
ConstanceBeguier
authored
40e7e10

Commits on Jan 28, 2025

Add NULLIFIER_L constant
ConstanceBeguier
authored
01e85a5

Commits on Feb 4, 2025

Refactor AssetSupply to AssetRecords and update issuance verification functions (#138)
dmidem
authored
a95364c

Commits on Feb 6, 2025

Fix cargo clippy warnings in PR #138 (#140)
dmidem
authored
b62f72a

Commits on Mar 12, 2025

Merge PCZT into zsa1
ConstanceBeguier
committed
b8d4543

Commits on Mar 17, 2025

Extend Orchard protocol flavor derives (#144)
dmidem
authored
e88e261

Commits on Apr 7, 2025

Add ZSA feature into PCZT
ConstanceBeguier
committed
aeec27d
Merge branch 'zsa1' into merge_pczt
ConstanceBeguier
committed
123a2f4

Commits on Apr 17, 2025

Commits on Apr 19, 2025

Reduced Circle CI and github CI runtime (#158)
PaulLaux
authored
c7d57b1

Commits on Apr 22, 2025

Lock Sinsemilla version (#160)
ConstanceBeguier
authored
37101f4

Commits on Apr 24, 2025

Commits on May 1, 2025

Commits on May 6, 2025

Use fixed size array for asset_id (#162)
PaulLaux
authored
f2411a0
Simplify compute_asset_desc_hash function (#161)
ConstanceBeguier
authored
9a25bd1

Commits on May 22, 2025

Use the last version of zcash_note_encryption (#165)
ConstanceBeguier
authored
7e4f28c

Commits on Jul 1, 2025

Commits on Jul 8, 2025

Update zcash_note_encryption crate (#171)
ConstanceBeguier
authored
fdd69e2

Commits on Jul 15, 2025

Commits on Jul 23, 2025

Commits on Jul 28, 2025

Commits on Jul 31, 2025

Simplify ZSA implementation (#178)
ConstanceBeguier
authored
58b710b

Commits on Aug 5, 2025

Remove native_asset_base prop_compose function (#180)
ConstanceBeguier
authored
0982ff6

Commits on Aug 26, 2025

Add rho derivation check in verify_issue_bundle (#183)
ConstanceBeguier
authored
826dc03

Commits on Sep 1, 2025

Commits on Sep 8, 2025

Commits on Sep 11, 2025

Update zcash_note_encryption (9f7e93) (#190)
ConstanceBeguier
authored
d18f0d5

Commits on Sep 12, 2025

Fix issuance_digest, issuance_auth_digest and orchard_digest (#189)

ConstanceBeguier
and
vivek-arte
authored
962564b

Commits on Sep 22, 2025

Updates to property testing (#191)
vivek-arte
authored
78b6f76

Commits on Sep 23, 2025

Create OrchardSighashVersion and IssueSighashVersion enum (#192)
ConstanceBeguier
authored
cf6d3b6

Commits on Oct 1, 2025

Add spend_auth_sigs_auth_digest into orchard_auth_digest (#193)
ConstanceBeguier
authored
abd6ecc

Commits on Oct 21, 2025

Shuffle actions in a Bundle (#194)
ConstanceBeguier
authored
fc73b8e

Commits on Oct 28, 2025

Fix split note in PCZT (#195)
ConstanceBeguier
authored
a7de16f

Commits on Oct 29, 2025

Remove PCZT v2 (#196)
ConstanceBeguier
authored
2083efe

Commits on Nov 3, 2025

Remove dev-only numeric-extension patterns mistakenly committed to .gitignore (#198)
dmidem
authored
a02fdf1

Commits on Dec 23, 2025

PR471 review: CI: disable LTO in release tests; add apt update to Ubuntu steps (#205)
dmidem
authored
7a44ba5

Commits on Jan 6, 2026

PR471 review: various fixes (2) (#208)

dmidem
and
ConstanceBeguier
authored
f83d652
PR471 review: add IssuanceFlags to handle ZIP 230 issuance flags byte (#210)

dmidem
and
ConstanceBeguier
authored
313544d
PR471 review: fix arb_asset_base generation (#211)

dmidem
and
ConstanceBeguier
authored
0589642
PR471 review: implement ShieldedOutput for pczt::Action (#212)

dmidem
and
ConstanceBeguier
authored
bb84ff2
PR471 review: pass asset as an argument into action proptest generators (#213)

dmidem
and
ConstanceBeguier
authored
accdd2f
PR471 review: various fixes (1) (#207)

dmidem
and
ConstanceBeguier
authored
b5518f1
PR471 review: remove expiry_height (#203)
ConstanceBeguier
authored
6c3de5d
PR471 review: update circuit files (#204)
ConstanceBeguier
authored
4f03573
PR471 review: use num_actions into build_bundle (#202)
ConstanceBeguier
authored
e48d478

Commits on Jan 8, 2026

Revert Value and ValueSum API changes per review feedback (#217)

dmidem
and
ConstanceBeguier
authored
27e6824
PR471 review: various comments (#206)
ConstanceBeguier
authored
f0cf7ea
Fix tests for no-default-features (#218)
ConstanceBeguier
authored
9f16cee

Commits on Jan 9, 2026

PR471 review: gate ZSA issuance behind zsa-issuance feature (#214)

dmidem
and
ConstanceBeguier
authored
f85cc40

Commits on Jan 12, 2026

Commits on Jan 13, 2026

PR471 review: export issuance empty-hash helpers (#220)

dmidem
and
ConstanceBeguier
authored
7259000
PR471 review: make ValueSum::from_raw public (#224)
ConstanceBeguier
authored
00e76f9
PR471 review: Add AssetId enum (#223)
ConstanceBeguier
authored
382f319

Commits on Jan 14, 2026

PR471 review: fix rho value for the issuance note (#225)
ConstanceBeguier
authored
7aafdc0

Commits on Jan 15, 2026

Commits on Jan 16, 2026

PR471 review: various comments (#228)
ConstanceBeguier
authored
dc861af

Commits on Jan 19, 2026

Commits on Jan 20, 2026

Commits on Jan 22, 2026

Commits on Jan 29, 2026

Commits on Feb 2, 2026

PR471 Review: Added MAX_BURN_VALUE
PaulLaux
committed
49f5939
PR471 Review: Removed redundent clippy directives.
PaulLaux
committed
1d93e5f

Commits on Feb 3, 2026

PR471 review: updated visiability for create_split_note() to pub(crate)
PaulLaux
committed
9d2960c

Commits on Feb 4, 2026

PR471 review: Fixed link to ZIP 226 / Note structure and Commitment
PaulLaux
committed
ec35bcc
PR471 Review: Removed redundant review hint.
PaulLaux
committed
fec254a

Commits on Feb 5, 2026

Commits on Feb 11, 2026

Commits on Feb 17, 2026

Update the test vectors based on the changes made in `zcash-test-vectors` (#238)

vivek-arte
and
dmidem
authored
3ec9f6f

Commits on Feb 18, 2026

Commits on Mar 2, 2026

Remove create_test_reference_note (Zebra now gets reference notes from IssueBundle in tests) (#242)
dmidem
authored
255a208

Commits on Mar 6, 2026

Address review comments from zcash PR #471 (2) (#243)
ConstanceBeguier
authored
03daf66

Commits on Mar 9, 2026

Merge branch 'zcash-main' into merge_upstream_20260309
ConstanceBeguier
committed
d45da40

Commits on Mar 10, 2026

Fix issues
ConstanceBeguier
committed
4b39a10

Commits on Mar 17, 2026

Merge upstream 20260309 (#244)

authored
92db1ee

Commits on Mar 30, 2026

Add IssueBundle::note_commitments to expose extracted note commitments (#245)
dmidem
authored
77d3274

Commits on May 4, 2026

Fix CI (#247)

authored
a7cb4b5

Commits on May 5, 2026

(Circuit) Pin q_init points to constants (#246)
ConstanceBeguier
authored
59ce48d

Commits on Jun 16, 2026

Merge branch 'zcash-main' into merge_upstream_20260609
ConstanceBeguier
committed
5723ae4
Update halo2 in Cargo.toml
ConstanceBeguier
committed
ac82e19
Fix clippy
ConstanceBeguier
committed
1e5e13e
Fix new tests in src/action.rs
ConstanceBeguier
committed
c881000
Fix tests
ConstanceBeguier
committed
7842b2c
Update expected_proof_size
ConstanceBeguier
committed
72784d7
Fix intra-doc links
ConstanceBeguier
committed
44afad1
Update README
ConstanceBeguier
committed
33f10e3

Commits on Jun 17, 2026

Move circuit_data folder
ConstanceBeguier
committed
e187c15
Simplify expected_proof_size implementation
ConstanceBeguier
committed
05040ba

Commits on Jun 23, 2026

Prevent ZSA proofs on insecure ECC chips
ConstanceBeguier
committed
bb309ad

Commits on Jun 24, 2026

Add a comment
ConstanceBeguier
committed
045ca8a

Commits on Jun 29, 2026

Merge upstream 20260609 (#251)
PaulLaux
authored
cf801a5

Commits on Jul 17, 2026

Commits on Jul 20, 2026

Take into account Pablo's comments
ConstanceBeguier
committed
f374f0c
Merge upstream 20260714 (#255)
PaulLaux
authored
af0d1b6

Commits on Jul 28, 2026

Support cross-address restriction in the ZSA circuit (#257)
ConstanceBeguier
authored
00d2c0f

Commits on Jul 29, 2026

Limit code coverage CI job to 10 minutes (#262)
PaulLaux
authored
b578ad9

Commits on Aug 5, 2026

Copy circuit files from remove_orchard_primitives branch
ConstanceBeguier
committed
88f04ac
Re-apply last modifications from upsatream
ConstanceBeguier
committed
085b763
Copy src/note/asset_base.rs from remove_orchard_primitives
ConstanceBeguier
committed
d27629e
Add TODO ZSA
ConstanceBeguier
committed
08a7d86
Remove tests from circuit_zsa file
ConstanceBeguier
committed
cebb133
Copy constants/nullifier_l.rs from remove_orchard_primitives
ConstanceBeguier
committed
668ce6e
Add patch for halo2 in Cargo.toml
ConstanceBeguier
committed
1a623a8
Copy constants/sinsemilla.rs from remove_orchard_primitives
ConstanceBeguier
committed
1b3e89f
Add patch for sinsemilla in Cargo.toml
ConstanceBeguier
committed
1f4edbf
Add NoteCommitTrapdoor::new function
ConstanceBeguier
committed
35eff9a
Update visibility of NoteCommitment::derive
ConstanceBeguier
committed
a88102a
Add asset and rseed_split_note into Note
ConstanceBeguier
committed
c3dd652
Update expected_proof_size function
ConstanceBeguier
committed
605b6e1
Fix from_action_context_common
ConstanceBeguier
committed
4556f5b
Add split_flag into SpendInfo
ConstanceBeguier
committed
a95e381
Add zsa_enabled flag
ConstanceBeguier
committed
ff93f2a
Remove unused imports
ConstanceBeguier
committed
5879844
Update flags
ConstanceBeguier
committed
9a25cc8
Remove some TODO ZSA
ConstanceBeguier
committed
3fa3865
Fix circuit_data paths
ConstanceBeguier
committed
c7e5ad4
Add asset into NoteCommitment::derive function
ConstanceBeguier
committed
a25dcac
Add asset into OutputInfo
ConstanceBeguier
committed
da5c21a
Reduce diff with upstream
ConstanceBeguier
committed
42c2409
Move OchardCircuitVersion out of circuit module to avoid feature gating
ConstanceBeguier
committed
6f2a9c4

Commits on Aug 6, 2026

Reduce visibility of some structures
ConstanceBeguier
committed
fa0db48
Update changelogs
ConstanceBeguier
committed
fc22c99

Commits on Aug 24, 2026

Circuit configure unify (#270)

PaulLaux
and
ConstanceBeguier
authored
c5ca73f

Commits on Aug 25, 2026

Add some checks on enable_zsa
ConstanceBeguier
committed
21bfb22
Update nu6_3_flags_parsing_handles_the_cross_address_bit test
ConstanceBeguier
committed
8335a20
update visibility of derive_nullifier when feature=unstable-voting-circuits
ConstanceBeguier
committed
c630436
Add check in ActionInfo::build_for_pczt
ConstanceBeguier
committed
d22b81d
Update comment
ConstanceBeguier
committed
56476c0
Remove AssetBase::hash
ConstanceBeguier
committed
00d93c7
Restore ValueCommit::derive and add ValueCommit::derive_with_asset
ConstanceBeguier
committed
a5917f4
Add non_echaustive on OrchardCircuitVersion
ConstanceBeguier
committed
59fdc71
Add non_exhaustive on OrchardHashDomains
ConstanceBeguier
committed
a111d57
Add ZSA circuit tests
ConstanceBeguier
committed
14833f9
Reduce diff with upstream in circuit.rs
ConstanceBeguier
committed
f731f05
Reduce diff with upstream
ConstanceBeguier
committed
dde720e
Add a test to pin zsa circuit description
ConstanceBeguier
committed
fccc31c
Update changelog
ConstanceBeguier
committed
c4eabd0
Check that spend and output asset match
ConstanceBeguier
committed
6a36957
Add TODO ZSA
ConstanceBeguier
committed
033664f
Update RestrictionUnsupportedByKey comment
ConstanceBeguier
committed
dea3298
update comment for OrchardCircuitVersion::ZSA
ConstanceBeguier
committed
4861917

Commits on Aug 26, 2026

Remove orchard_sinsemilla_chip.rs file
ConstanceBeguier
committed
6ac887e
Create a constant for zatoshi asset base
ConstanceBeguier
committed
ff917a0
Zsa circuit v1 add (#274)
PaulLaux
authored
ecd69c5
Update Note::nullifier implementation and add tests
ConstanceBeguier
committed
7b7005b
Add assert to check (split_flag, rseed_split_note)
ConstanceBeguier
committed
356d6ef
Add Note::psi_nf
ConstanceBeguier
committed
e92ae6b
Update circuit_zsa tests
ConstanceBeguier
committed
aae1a8f
Update changelog
ConstanceBeguier
committed
bd89e5d
Update changelog
ConstanceBeguier
committed
b7a6bee
Update changelog
ConstanceBeguier
committed
828308b
Document the split_flag consistency panic
PaulLaux
committed
c6dd0db
Test the split-note branch of Note::nullifier
PaulLaux
committed
2b4c83b
Update comments
ConstanceBeguier
committed
1cc6b4e

Commits on Aug 27, 2026

Doc+new test (#275)
PaulLaux
authored
ffa23b3

Commits on Aug 31, 2026

Reduce OrchardPrimitives generic parameter usage (#261)

ConstanceBeguier
and
PaulLaux
authored
e001a78

Commits on Sep 1, 2026

Move allocation of table_range_check_tag (#279)
ConstanceBeguier
authored
837ddd1

Commits on Sep 2, 2026

Commits on Sep 3, 2026

Make the zero-padding comment generic (#281)
ConstanceBeguier
authored
5170054
Align test in circuit_zsa.rs from zsa_circuit_v1 branch
ConstanceBeguier
committed
2287a3a
Update from_parts_internal to be only usable in tests
ConstanceBeguier
committed
fdaae96
Align circuit_zsa tests with the zsa1 branch (#283)

ConstanceBeguier
and
PaulLaux
authored
67a3c66
Merge branch 'zsa_circuit_v1' into merge_zsa_circuit
ConstanceBeguier
committed
bf3a8a4
Remove TODO ZSA in circuit_zsa.rs
ConstanceBeguier
committed
0a092fb
Add some tests on enable_zsa flags
ConstanceBeguier
committed
49eb768

Commits on Sep 4, 2026

Update halo2 patches in Cargo.toml
ConstanceBeguier
committed
b9c5e4d
Update the halo2 patches to upstream zcash/halo2
ConstanceBeguier
committed
744469a

Commits on Sep 5, 2026

Update the halo2 patches to upstream zcash/halo2 (#286)
PaulLaux
authored
bd88a58

Commits on Sep 8, 2026

Remove zsa1 changes in changelog
ConstanceBeguier
committed
290a1b0
Add batched_compact_decryption_matches_per_item_zsa test
ConstanceBeguier
committed
8b2f280
Remove compact_ciphertext_size from tests
ConstanceBeguier
committed
9d496d3
Rename only_orchard_zsa_permits_zsa with zsa_is_permitted_correctly
ConstanceBeguier
committed
7cae48b
Update comment
ConstanceBeguier
committed
afd1de3
Fix scope in create_split_spend
ConstanceBeguier
committed
f66cd36
Comment out split_note_nullifier test
ConstanceBeguier
committed
a8ed7cc
Merge zsa_circuit_v1 into zsa1 (#284)
PaulLaux
authored
7994111

Commits on Sep 10, 2026

Add rcm_zsa (#265)
ConstanceBeguier
authored
fdccb59

Commits on Sep 11, 2026

Add Orchard V3 and Ironwood V3 fixed digest tests (#266)
ConstanceBeguier
authored
8d1bf46

Commits on Sep 16, 2026

Re-export OrchardCircuitVersion from the circuit module (#291)
dmidem
authored
71aea69

Commits on Sep 23, 2026

Issuance fixes and cleanup (#249)

authored
e40bdfa