fix: compute a single IIS in Xpress infeasibility path#658
Open
FabianHofmann wants to merge 1 commit intomasterfrom
Open
fix: compute a single IIS in Xpress infeasibility path#658FabianHofmann wants to merge 1 commit intomasterfrom
FabianHofmann wants to merge 1 commit intomasterfrom
Conversation
Previously `_compute_infeasibilities_xpress` called `iisall()` and merged every IIS into one deduplicated set, losing per-IIS grouping. Switch to `firstIIS(2)` (with `iisfirst(2)` fallback) so a single IIS is returned, matching the Gurobi behavior.
Collaborator
Author
|
would like to make a patch release with this and #605 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Model._compute_infeasibilities_xpressnow computes a single IIS viafirstIIS(2)(new Xpress API) withiisfirst(2)as deprecated-API fallback, instead of callingiisall()and iterating every IIS.set, flattening per-IIS grouping and returning an ambiguous union. With only one IIS computed, the returnedlist[int]matches the Gurobi path's semantics.2asks Xpress for a proper IIS optimised for a quick result (mode0would return a non-minimal infeasible subproblem; mode1optimises for minimality at higher cost).Upcoming Version.Checklist
doc.doc/release_notes.rstof the upcoming release is included.