feat: add __weakref__ to Model.__slots__#656
Merged
Conversation
This was referenced Apr 20, 2026
Enables weakref.ref() and WeakKeyDictionary-based per-instance storage for third-party extensions (e.g. accessor-style libraries) without requiring users to subclass Model. Closes #655 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
FBumann
force-pushed
the
feat/model-weakref
branch
from
19d5427 to
bbd7ffb
Compare
Collaborator
Author
|
@FabianHofmann I need this to improve the UX of linopy-yaml. See #561 . Also probably needed for things like #645. |
FabianHofmann
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__weakref__toModel.__slots__soweakref.ref(model)andWeakKeyDictionarykeyed byModelwork.Modelor reintroduce__dict__.Closes #655
Test plan
test_model_is_weakrefable—weakref.ref(Model())returns a live reference.test_model_weakkeydict_use_case— entries in aWeakKeyDictionary[Model, ...]are GC'd when the model is deleted.test/test_model.pysuite still passes (20 tests).🤖 Generated with Claude Code