Repository navigation
docs: settle the config format on F2, add GitHub - #9
Merged
Merged
Conversation
CONFIGURATION_PROPOSAL.md now specifies F2, a `kind` key with the keys Backend.connect() takes, which keeps caldav's file and calendaring-jmap's key names in one file. Prefixed keys (F1) and a new TOML file (F3) are reduced to a few words each. From the review of the earlier draft: env vars win over the file, a `_command` is an argument list run without a shell and refused from a file others can write. Rechecking caldav's parser found an inherits leak across backends and an unsafe yaml.Loader, and backward compatibility is now wanted rather than required. GitHub goes on the roadmap as the first unfunded tracker after Gitea. Prompt: Start working on roadmap 1.4 - configuration file. Suggest some few different alternatives for how to do it. The configuration file needs to be compatible with the current caldav configuration file, but it should also support jmap, icalendar files, and arbitrary other backends (gitea being one of the first - and even if it's not funded, I think we should prioritize github since it's what we're using internally. Please look through the roadmap and add GitHub). Also look into the jmap-client, it should be cloned locally from the pycalendar org on github ... "needs to" is perhaps a bit strong wording - it would be nice to be backward compatible, if nothing else Followup-Prompt: #6 was closed by accident. Anyway, it was a draft with three different suggestions for the config file. Resurrect the content, choose the 2nd alternative (recommended by Claude and preferred by me and Sashank), summarize the alternatives in some few words, and make a new pull request, maybe with a clean commit from master. Assisted-By: Claude Opus 5.5 via Claude Code Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
tobixen
added
documentation
The PR 6 points were already in the spec, but "environment variables win, as in both libraries" was not true: caldav lets any CALDAV_* connection variable replace the whole file. Specify the rule per kind: an env URL skips the file, other variables override the one section read key by key, as calendaring-jmap does. Also list caldav's real search path and note that calendaring-sync has no configuration. Prompt: (...). Please ensure that those details are in the spec [from the last comments in #6]. Please check how the caldav implementation works today. Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #6, which was closed by accident (its base branch,
roadmap-1.1, went away when #5 merged). The discussion is still there.PR 6 put three config formats up for comparison. This PR settles on the second one, F2, which Claude recommended and Sashank and I prefer. F1 and F3 are now summarised in a sentence each. The points agreed in the PR 6 thread are written into the spec:
_commandtakes an argument list and runs without a shell_commandfile is refused if others can write to itWhere the parser lives (option B or C) is still open.
🤖 Generated with Claude Code