Skip to content

Richer event search filters - #57

Merged
SashankBhamidi merged 1 commit into
mainfrom
feat/richer-event-search
Sep 29, 2026
Merged

SashankBhamidi merged 1 commit into
mainfrom
feat/richer-event-search

Conversation

@SashankBhamidi

Copy link
Copy Markdown
Member

Closes #17.

search_events only handled calendar, date range, and free text before this. I added has_attachment, participant_email, participation_status, and participant_role on both the sync and async client, plus JMAPCalendar.search.

I went looking for where these map onto FilterCondition and they don't. The real spec only has ten properties there, and the two that come closest, owner/attendee, are free-text name-or-email searches scoped to a single role, not exact-match filters at all. So all four run client-side instead, against whatever the server's own filters already returned.

Cyrus drops a Link's rel: "enclosure" on read-back, so has_attachment=True misses real attachments there. Both Cyrus and Stalwart strip the attendee role from a participant's roles map specifically, whatever else is on it, so participant_role="attendee" misses matches on both, but a participant who's also chair keeps that role and still matches on it.

@codecov

codecov Bot commented Sep 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@read-the-docs-community

Copy link
Copy Markdown

@SashankBhamidi
SashankBhamidi merged commit 58e0724 into main Sep 29, 2026
12 checks passed
@SashankBhamidi
SashankBhamidi deleted the feat/richer-event-search branch September 29, 2026 05:03
@niccokunzmann

Copy link
Copy Markdown
Member

You said in the RFP that you created a test server.
Could you link the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Richer event search filters

2 participants