Repository navigation
Richer event search filters - #57
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Documentation build overview
|
Member
|
You said in the RFP that you created a test server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17.
search_eventsonly handled calendar, date range, and free text before this. I addedhas_attachment,participant_email,participation_status, andparticipant_roleon both the sync and async client, plusJMAPCalendar.search.I went looking for where these map onto
FilterConditionand they don't. The real spec only has ten properties there, and the two that come closest,owner/attendee, are free-text name-or-email searches scoped to a single role, not exact-match filters at all. So all four run client-side instead, against whatever the server's own filters already returned.Cyrus drops a Link's
rel: "enclosure"on read-back, sohas_attachment=Truemisses real attachments there. Both Cyrus and Stalwart strip theattendeerole from a participant'srolesmap specifically, whatever else is on it, soparticipant_role="attendee"misses matches on both, but a participant who's alsochairkeeps that role and still matches on it.