Skip to content

chore(ci): Fix race condition / comment timing between Welcome Bot and Logic Verification #85

Description

@itsdakshjain

The Situation

We currently have two separate GitHub Actions workflow files running when a Pull Request is opened:

  1. welcome-bot.yml (Welcomes first-time contributors)
  2. logic-verification.yml (Runs unit tests and verifies that 1 is still 1)

The Problem

Because our unit test suite runs lighting-fast, the Logic Verification CI workflow finishes running and comments ✅ Logic Verified! on the PR before the Welcome Bot finishes checking the user database and posting its welcome message.

Visually, this looks out of order in the PR timeline. The welcoming message should always appear first before the technical verification results layout.

The Goal

We want to ensure that the Welcome Bot always successfully posts its comment before the Logic Verification bot posts its success/failure message.

CRITICAL REQUIREMENT: We want to keep these as two separate YAML workflow files to maintain modularity. We do not want to combine them into a single file.

How to Contribute

  1. Fork the repository.
  2. Figure out a clean way to do it
  3. Open a Pull Request with your solution!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ci/cdGitHub Actions and automated workflow triggers.enhancementNew feature or requestgood first issueGood for newcomershelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions