chore(android): align the plugin's AGP classpath with the example's 9.4.0 - #154
Merged
Conversation
….4.0 #145 landed AGP **9.4.0** in `purchasely/example/android/settings.gradle` — not the 9.3.1 its title says: Dependabot re-targeted to the latest when it rebased. #143, which would have moved `purchasely/android`'s buildscript classpath, was closed as superseded and its branch deleted, so the two declarations diverged: example/settings.gradle com.android.application 9.4.0 (effective) purchasely/android com.android.tools.build 9.0.1 (stale) The classpath here only takes effect for a standalone module build — when Flutter builds the plugin as part of the example, the applied version comes from the example's pluginManagement. So this is not a build fix; it is keeping the two declarations from drifting, which is what makes the next AGP bump reviewable. Both wrappers clear AGP 9.4's Gradle floor: `purchasely/android` on 9.7.1 (#150), the example on 9.6.1 (#140). Verified: `flutter build apk --debug` green on the example, which exercises the effective AGP. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No reviewable files after applying ignore patterns. |
macminisupport
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #145 / #143.
#145 landed AGP 9.4.0 in the example's
settings.gradle— not the 9.3.1 its title says; Dependabot re-targeted to the latest when it rebased. #143, which would have movedpurchasely/android's buildscript classpath, was closed as superseded and its branch deleted, leaving the two declarations divergent:purchasely/example/android/settings.gradlecom.android.application9.4.0purchasely/android/build.gradlecom.android.tools.build:gradle9.0.1This is not a build fix — when Flutter builds the plugin as part of the example, the applied AGP comes from the example's pluginManagement. It keeps the two declarations from drifting, which is what makes the next AGP bump reviewable instead of confusing.
Both wrappers clear AGP 9.4's Gradle floor:
purchasely/androidon 9.7.1 (#150), the example on 9.6.1 (#140).Verified locally:
flutter build apk --debuggreen on the example.🤖 Generated with Claude Code