fix: prevent API key leak to untrusted download URLs#506
Open
JannikSt wants to merge 3 commits into
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5319d9c34
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents sending the Authorization header when downloading env packages from URLs that don't match the trusted API host.
Note
Medium Risk
Tightens authentication header handling in environment downloads, which can affect access to private env artifacts if download URLs are not HTTPS or don’t match the configured API host. Also changes tar extraction behavior to fail on additional validation errors.
Overview
Prevents leaking credentials during
prime env pulland private env downloads by only attaching theAuthorizationheader when thedownload_urlis HTTPS and matches the configured API host (_is_trusted_url).Switches archive extraction in
pullto use_safe_tar_extractand treats validation failures (ValueError) as extraction errors, improving protection against malicious tar contents.Reviewed by Cursor Bugbot for commit c8118f3. Bugbot is set up for automated code reviews on this repo. Configure here.