dnsdist: add bloom filter accessible from Lua - #17890
Conversation
Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>
Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>
Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>
Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>
Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>
Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>
Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>
|
This depends on #17561 - if and once that gets merged, I will rebase this. |
Coverage Report for CI Build 31519278567Coverage increased (+1.4%) to 68.452%Details
Uncovered Changes
Coverage Regressions3587 previously-covered lines in 68 files lost coverage.
Coverage Stats💛 - Coveralls |
|
It looks like there is a custom Bloom filter implementation in here. I would instead recommend the (heavily optimized and reviewed) Bloom filter that was added to Boost recently (https://www.boost.org/doc/libs/latest/libs/bloom/doc/html/bloom.html) even though it requires a more up-to-date Boost than is typically available in the stable distros. |
Thanks for the suggestion. I just used the implementation that was already present and used in the project - seemed like the safest option. |
|
I like the idea, and I agree using the existing implementation is the right thing to do (whether we might want to switch to the Boost one when available is a different discussion). Let's get #17561 merged first (I have been lagging behind, sorry about that). |
|
Understood - sorry about all of these drafts, I wanted to get them in a reviewable state, because I have been dragging it around in WIP branches for some time. |
Short description
Further extends #17561 with a bloom filter instead of a cache, allowing presence checks with a lower memory usage.
Checklist
I have: