auth: allow EDNS Client Subnet prefix to be narrowed - #17879
Open
miodvallat wants to merge 3 commits into
Open
Conversation
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
Coverage Report for CI Build 31175548763Coverage increased (+9.4%) to 71.205%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions23753 previously-covered lines in 295 files lost coverage.
Coverage Stats💛 - Coveralls |
Habbie
reviewed
Aug 9, 2026
Habbie
left a comment
Member
There was a problem hiding this comment.
first commit (from other PR) already looked good to me. Second commit (wrapup cleanup) looks good to me but deserves another pair of eyes.
Third commit also looks good, but needs docs. I'd also like rec and dnsdist people to have a brief look (perhaps once docs are written) to make sure all our products interact correctly with this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds two new settings,
edns-scope-mask-ipv4andedns-scope-mask-ipv6, which will be used to narrow the scope mask in EDNS responses, except for packets which have hit a view, in which case the view netmask is still used.Note that this PR is built ontop the first commit of #17878. No need to review more than once.
This could help people mitigate #16803.
Todo:
Checklist
I have: