Skip to content

feat(personhog): add FoldPersonDocument leader RPC #79225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trunk-io merged 10 commits into from
Aug 9, 2026
Merged

feat(personhog): add FoldPersonDocument leader RPC #79225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6455362
feat(personhog): add FoldPersonDocument leader RPC
nickbest-ph Aug 6, 2026
d7fef80
chore(personhog): add fold precedence edge-case tests
nickbest-ph Aug 6, 2026
a91531e
fix(personhog): deliver semantic leader refusals through the router
nickbest-ph Aug 7, 2026
4472767
fix(personhog): verify the fold's target mark and scope its trim
nickbest-ph Aug 7, 2026
6181e9c
fix(personhog): carry last_seen_at through the fold
nickbest-ph Aug 7, 2026
4815479
fix(personhog): validate snapshot identity and sanitize the fold target
nickbest-ph Aug 7, 2026
fdad122
feat(personhog): fold precedence follows snapshot ordinals
nickbest-ph Aug 7, 2026
f24f4c4
chore(personhog): extract sealed-snapshot admission into a helper
nickbest-ph Aug 7, 2026
2a93e5f
fix(personhog): stub the fence RPCs in the node fake service
nickbest-ph Aug 7, 2026
9958208
chore(personhog): lease fence-test lifecycle ops out of the sweeper's…
nickbest-ph Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion nodejs/src/common/generated/personhog/personhog/service/v1/service_pb.ts
View file
Open in desktop

Large diffs are not rendered by default.

352 changes: 349 additions & 3 deletions nodejs/src/common/generated/personhog/personhog/types/v1/person_pb.ts
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions nodejs/src/common/personhog/client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,9 @@ const SERVICE_DEFAULTS: ServiceImpl<typeof PersonHogService> = {
splitPerson: () => ({ splits: [] }),
setPersonDistinctIdVersionFloor: () => ({}),
setPersonVersionFloor: () => ({ updated: false }),
fencePerson: () => ({}),
releaseFence: () => ({}),
foldPersonDocument: () => ({}),
}

function createMockClient(overrides: Partial<ServiceImpl<typeof PersonHogService>> = {}): PersonHogClient {
Expand Down
3 changes: 3 additions & 0 deletions nodejs/src/common/personhog/persons.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ const SERVICE_DEFAULTS: ServiceImpl<typeof PersonHogService> = {
splitPerson: () => ({ splits: [] }),
setPersonDistinctIdVersionFloor: () => ({}),
setPersonVersionFloor: () => ({ updated: false }),
fencePerson: () => ({}),
releaseFence: () => ({}),
foldPersonDocument: () => ({}),
}

function createOperations(overrides: Partial<ServiceImpl<typeof PersonHogService>> = {}): {
Expand Down
4 changes: 2 additions & 2 deletions posthog/personhog_client/proto/generated/personhog/service/v1/service_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 47 additions & 0 deletions posthog/personhog_client/proto/generated/personhog/service/v1/service_pb2_grpc.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading