fix(email): stop blocking inline email sends on an analytics flush by mayteio · Pull Request #124631 · PostHog/posthog

mayteio · 2026-10-28T08:57:29Z

Problem

Signup and login requests that send an email inline wait for an analytics event upload before they respond.
#122019 moved email events onto ph_scoped_capture, which builds a new client per send and calls a blocking shutdown().
The upload goes to US ingestion, so EU requests wait on a cross-region call.
Raised in this Slack thread.

Changes

Emails sent inside a request no longer wait on the analytics upload. Users see the signup and login responses sooner.
A send outside a Celery worker task uses the global posthoganalytics client. That client uploads in the background and already sets the region super property.
A send that a Celery worker runs keeps ph_scoped_capture, so a recycled worker child still flushes its events.
Both paths keep the is_cloud() guard, so a self-hosted instance sends no recipient addresses to the PostHog analytics project.
Event names and properties do not change.
Gap: an eager send nested inside another worker task uses the global client. This matches the behavior before feat(email): send transactional emails through workflows behind a flag #122019.

How did you test this code?

Test rationale: test_send_via_http_flushes_events_only_in_a_worker covers which client a send uses. It fails if a request send blocks on the scoped flush, if a worker send skips it, or if a self-hosted send captures events. The existing posthog/test/test_email.py cases still assert every captured event and its properties.

Ran hogli test posthog/test/test_email.py locally.
Not checked: the latency effect in production. Watch the signup and login POST latency after deploy.

Release status

No feature flag controls this change

Docs update

None.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Agent: PostHog Desktop (Claude Code), Opus 5.5 (claude-opus-5-5)

Skills invoked: /writing-tests, /writing-pr-descriptions.
PostHog Review findings led to the worker and request split and to keeping the cloud guard. The first version used the global client for every send.
This PR removes only the analytics flush. The inline Workflows send that signup and login codes now make is a separate cause of the slowdown, and it is out of scope here.
The search for open PRs that fix this found none.

Created with PostHog Desktop

🤖 Generated with Claude Code

HTTP email sends captured their events through ph_scoped_capture, which builds a client per send and waits for it to upload before returning. Requests that send an email inline, such as signup and login codes, waited on that upload. Capture through the global posthoganalytics client again, which already sets the region super property and uploads in the background. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 43b649a0-cb22-4866-8c03-fb38148fd5ac

trunk-io · 2026-10-28T08:57:33Z

😎 Merged successfully - details.

parameterai · 2026-10-28T08:59:00Z

Risk: No findings

This change routes inline (web-request) email analytics through the global posthoganalytics client instead of the per-send flushing client, so signup/login responses no longer wait on a cross-region analytics upload; Celery worker sends keep the dedicated flushing client. Both transports keep the cloud-only guard and the region super property, so I found no security regression — only the acknowledged, documented risk that an event enqueued just before a process exit can be lost.

_{Sentinel reviewed 5374e8c · Review settings}

github-actions · 2026-10-28T08:59:10Z

🤖 CI report

⚠️

Trunk lane — backend Python lane

This PR is assigned to the backend Python lane. It runs backend Python tests and may merge in parallel with PRs in other lanes.

✅ Duplication (Python) — clean

New Python code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

✅ Duplication (TypeScript) — clean

New TypeScript code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

⚠️

Comment density — 3% of added code lines are comments (2 of 58)

This section warns when comments are more than 3% of the code lines a PR adds, and alerts above 6%. Before agent-assisted PRs, the typical share was about 2%. Only full-line comments count. Docstrings, generated files, snapshots, migrations, and workflow files are left out.

Comments that restate the code, record how the change came about, or narrate the next line add noise for the next reader. Keep the comments that explain a reason the code cannot show, and remove the rest. See .agents/skills/writing-code-comments/SKILL.md for the house rules.

Files with the most added comment lines:

File	Comment lines	Added lines
`posthog/email.py`	2	5

This check does not block merging. It updates on every push and clears when the share drops.

✅ Playwright — all passed

All tests passed.

View test results →

posthog

PostHog Review · Standard · reviewed bba4c6b: 2 Should fix.

This Standard review started from the posthog-review label. Comment @posthog review --deep for a Deep review, or @posthog help to see all commands.

See this review and its findings in PostHog Review.

trunk-io · 2026-10-28T09:12:25Z

_{View Full Report ↗︎ ⋅ Docs}

yasen-posthog

Approved to unblock, just make sure to address the bot comments, and thank you 🙏

…uard A send that a Celery worker runs uses ph_scoped_capture again, so a recycled worker child does not drop the email events. Only sends outside a worker task, such as eager sends inside a request, use the global client. Both paths go through ScopedCapture, so a self-hosted instance does not send recipient addresses to the PostHog analytics project. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 43b649a0-cb22-4866-8c03-fb38148fd5ac

Generated-By: PostHog Desktop Task-Id: 43b649a0-cb22-4866-8c03-fb38148fd5ac

deployment-status-posthog · 2026-10-28T12:20:40Z

Deploy status

Environment	Status	Deployed At	Workflow
dev	✅ Deployed	2026-10-28 12:20 UTC	Run
prod-us	✅ Deployed	2026-10-28 12:40 UTC	Run
prod-eu	✅ Deployed	2026-10-28 12:38 UTC	Run

mayteio self-assigned this Oct 28, 2026

mayteio marked this pull request as ready for review October 28, 2026 08:58

mayteio added the posthog-review Run a Standard PostHog Review label Oct 28, 2026

pr-assigner-resolver-posthog Bot requested a review from a team October 28, 2026 09:00

posthog Bot reviewed Oct 28, 2026

View reviewed changes

Comment thread posthog/email.py Resolved

Comment thread posthog/email.py Resolved

posthog Bot removed the posthog-review Run a Standard PostHog Review label Oct 28, 2026

yasen-posthog approved these changes Oct 28, 2026

View reviewed changes

mayteio added 2 commits October 28, 2026 09:21

Merge branch 'master' into posthog/email-capture-no-blocking-flush

61ede72

Generated-By: PostHog Desktop Task-Id: 43b649a0-cb22-4866-8c03-fb38148fd5ac

trunk-io Bot merged commit bc2e932 into master Oct 28, 2026
255 checks passed

trunk-io Bot deleted the posthog/email-capture-no-blocking-flush branch October 28, 2026 12:00

Navigation Menu

Repository navigation

fix(email): stop blocking inline email sends on an analytics flush - #124631

fix(email): stop blocking inline email sends on an analytics flush#124631
trunk-io[bot] merged 3 commits into
masterfrom
posthog/email-capture-no-blocking-flush

mayteio commented Oct 28, 2026 •

edited

Loading

Uh oh!

trunk-io Bot commented Oct 28, 2026 •

edited

Loading

Uh oh!

parameterai Bot commented Oct 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 28, 2026 •

edited

Loading

Uh oh!

posthog Bot left a comment

Uh oh!

Uh oh!

Uh oh!

trunk-io Bot commented Oct 28, 2026 •

edited

Loading

Uh oh!

yasen-posthog left a comment

Uh oh!

Uh oh!

deployment-status-posthog Bot commented Oct 28, 2026 •

edited

Loading

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mayteio commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Changes

How did you test this code?

Release status

Docs update

🤖 Agent context

Uh oh!

trunk-io Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parameterai Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 CI report

Uh oh!

posthog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

trunk-io Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yasen-posthog left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

deployment-status-posthog Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploy status

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mayteio commented Oct 28, 2026 •

edited

Loading

trunk-io Bot commented Oct 28, 2026 •

edited

Loading

parameterai Bot commented Oct 28, 2026 •

edited

Loading

github-actions Bot commented Oct 28, 2026 •

edited

Loading

trunk-io Bot commented Oct 28, 2026 •

edited

Loading

deployment-status-posthog Bot commented Oct 28, 2026 •

edited

Loading