Repository navigation
trunk-merge/pr-124218/e7b63e5e-40db-43e4-aff4-f1859f611b7c - #124265
Closed
trunk-io[bot] wants to merge 131 commits into
Closed
trunk-io[bot] wants to merge 131 commits into
trunk-io[bot] wants to merge 131 commits into
Conversation
Include and exclude on a custom column cell used the column's label as the filter key. Once a column was renamed, that key named no attribute, so exclude removed no rows and include returned no logs. customColumnFilterTarget now reads the key and type from the column expression: the attributes. and resource_attributes. shorthands, the "Add as column" lookup expression, and a bare service_name column. Other HogQL keeps the label, as before. The popover's add/remove column toggle still keys on the label. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 updated Run: 42023344-91b7-4f07-b684-5ae8fad7ec9d Co-authored-by: lricoy <2034367+lricoy@users.noreply.github.com>
2 updated Run: 84cd4ff0-f6b0-4106-a717-ebb59d363e55 Co-authored-by: lricoy <2034367+lricoy@users.noreply.github.com>
# Conflicts: # products/aeo/mcp/tools.yaml # products/web_analytics/frontend/contentAutopilot/ContentAutopilot.stories.tsx # services/mcp/src/tools/generated/aeo.ts
# Conflicts: # products/aeo/mcp/tools.yaml # products/web_analytics/frontend/contentAutopilot/ContentAutopilot.stories.tsx # services/mcp/src/tools/generated/aeo.ts
# Conflicts: # services/mcp/tests/unit/tool-filtering.test.ts
…etail # Conflicts: # frontend/src/initKea.ts # products/aeo/README.md # products/aeo/backend/facade/api.py # products/aeo/backend/facade/contracts.py # products/aeo/backend/presentation/views.py # products/aeo/backend/test/test_api.py # products/aeo/mcp/tools.yaml # products/web_analytics/frontend/contentAutopilot/ContentAutopilotPrompts.tsx # products/web_analytics/frontend/contentAutopilot/contentAutopilotStoryFixtures.ts # products/web_analytics/frontend/contentAutopilot/utils.ts # products/web_analytics/frontend/generated/api.schemas.ts # products/web_analytics/frontend/generated/api.ts # services/mcp/schema/generated-tool-definitions.json # services/mcp/schema/tool-definitions-all.json # services/mcp/src/api/generated.ts # services/mcp/src/generated/aeo/api.ts # services/mcp/src/tools/generated/aeo.ts
# Conflicts: # products/aeo/backend/test/test_api.py # products/aeo/mcp/tools.yaml # products/web_analytics/frontend/contentAutopilot/ContentAutopilotPromptChecks.tsx # services/mcp/schema/generated-tool-definitions.json # services/mcp/schema/tool-definitions-all.json
…hecks as version 1
…ricoy/aeo-prompt-versions # Conflicts: # products/aeo/mcp/tools.yaml
Contributor
🤖 CI report
|
trunk-io
Bot
deleted the
trunk-merge/pr-124218/e7b63e5e-40db-43e4-aff4-f1859f611b7c
branch
October 27, 2026 17:49
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the master branch at SHA a9bd34eb85f250b6177985a66954feffacc67b93.
See more details about each PR in the batch here:
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing a batch with the changes from pull requests 124218, 123419, 123938, and 123999 - batching documentation.
Dependencies
This pull request depends on the changes from pull requests 124125, 122639, 124028, 123708, 122978, 124226, 121966, 123512, 121720, 123456, 124023, 123983, 124039, 124042, 124157, 123897, 123927, 124204, 124198, and 123698.