Repository navigation
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
|
||
| - **Sentence case.** Capitalize only the first word and proper nouns. "Save as view", not "Save As View". "Product analytics", not "Product Analytics". | ||
| - **Be direct and friendly.** Say what happened and what to do next. | ||
| - **Be direct and friendly.** Use short sentences and keep one tone across surfaces. Say what happened and what to do next. |
There was a problem hiding this comment.
| - **Be direct and friendly.** Use short sentences and keep one tone across surfaces. Say what happened and what to do next. | |
| - **Be direct and friendly.** Keep one tone across surfaces, say only what happened and what to do next. |
There was a problem hiding this comment.
Note
🤖 Claude Opus 5.5 responding on behalf of Michael
Applied in 4d14ea9, thanks!
| /.agents/architecture.md @PostHog/team-devex | ||
| /.agents/ci.md @PostHog/team-devex | ||
| /.agents/code-style.md @PostHog/team-devex | ||
| /.agents/feature-usage-tracking.md @PostHog/team-devex |
|
Risk: No findings This increment is CI-only: wrapping Sentinel reviewed |
👀 Auto-assigned reviewersThese soft owners were skipped because they only have minor changes here. Nothing blocks merge, so self-assign if you'd like a look:
Soft owners come from each directory's |
|
✅ Security review complete — No findings above the confidence threshold, in 6 min. Add the |
|
Note 🤖 Claude Opus 5.5 responding on behalf of Michael Confidence report: do agents pick up the moved rules?I took the recurring task shapes from my past Claude Code and Codex sessions in this repo and wrote 9 test cases from them. Each case needs a rule that now lives only in an Verdict: with the routing table from 5619465 and e8cc8cb, I'm confident in this for all four models.
What the first version missed
What I triedHaiku and Sonnet on the four weakest cases, 2 runs per cell:
Other findings
How I ran it
|
feliperalmeida
left a comment
There was a problem hiding this comment.
approved .github/CODEOWNERS changes.
4d14ea9 to
8a60702
Compare
Commit signatures resolvedGitHub now verifies every commit signature in this PR. No further action is needed. |
The root AGENTS.md loads in full in every agent session. Move the architecture, code style, CI, feature usage tracking, and agent automation rules into .agents/<topic>.md guides that agents read on demand, and leave one pointer line under each original heading. The user-facing copy bullets already live in /writing-user-facing-copy. Point the enforcement-tag invariant test, its CI path filter, CODEOWNERS, the stamphog agent_steering category, and every reference at the new guides. Root file: 46,010 bytes to 22,404 bytes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add the new guides to the frozen stamphog policy copy, repoint the remaining references to moved rules, and make the tag test read every .agents guide and reject rules under the root pointer headings. Widen three pointer lines to cover every trigger of the rules they replace, and promote Mandatory skill invocation to its own section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Haiku and Sonnet skipped the per-section pointers when a task only showed a diff to review, and missed guide-only rules there. A table that maps each area to its guide, and says a review counts, made every measured run open the right guide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The table and the old pointer lines named different triggers for the same guide, so they would drift. Each guide's row now holds its full trigger, and the section under each heading only names the guide. The editing-agents-md skill says where a new trigger goes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8a60702 to
d2ddf4e
Compare
Problem
AGENTS.mdin full before its first step, whatever the task.Changes
.agents/architecture.md.agents/code-style.md.agents/ci.md.agents/feature-usage-tracking.md.agents/agent-automation.md/writing-user-facing-copy, which already held every bullet. It gains "Keep one tone across surfaces", the one rule it lacked..agents/security.md, the existing home for agent guides read on demand.agent_steeringcategory now list the five files with the root file.test_agents_md_enforcement_tags.pychecks tags in the root file and every.agents/*.mdguide. It requires a tag on every rule in the architecture and code style guides.repo_invariantspath filter inci-backend.ymlnow matches.agents/*.md, so an edit to a guide still runs the test.test_policy.pygains the newagent_steeringpattern.AGENTS.mdfiles, six skills, the code-reviewer agent, two code comments, a semgrep message, the hooks warning, a dagster comment,.greptile/files.json, and.stamphog/README.md./organizing-conversations-code.Warning
🟡 Merge risk: medium · two-way door (merge-risk rubric)
How did you test this code?
Test rationale: the change rewires the existing invariant test. No new test is needed.
test_agents_md_enforcement_tags.pyand the stamphogtest_policy.pypass on the new layout..agents/code-style.md, a[lint: no-such-rule]tag in.agents/ci.md, and a rule under the root## Code Styleheading.Release status
Docs update
None. The change only moves agent instructions.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Agent: Claude Code, Claude Opus 5.5 (
claude-opus-5-5)/editing-agents-md,/writing-pr-descriptions,pr-description,merge-risk,leaving-pr-comments.frontend/src/AGENTS.md, because.agents/code-style.mdalready sends frontend work there..coderabbit.yaml, because CodeRabbit is retired here.AGENTS.mdin the title found none..agents/and not into a newdocs/agents/tree, because.agents/security.mdalready sets that pattern.🤖 Generated with Claude Code