fix(flags): align presence operator semantics - #235
Merged
Conversation
Contributor
posthog-rs-v0 Compliance ReportDate: 2026-08-26 07:50:58 UTC ✅ All Tests Passed!46/46 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
Contributor
posthog-rs-v1 Compliance ReportDate: 2026-08-26 07:51:07 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
|
Reviews (1): Last reviewed commit: "fix(flags): align presence operator sema..." | Re-trigger Greptile |
ioannisj
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
sdk-specs PR #49 defines omitted properties as inconclusive because SDK property maps contain partial context. The Rust local evaluator returned false for missing
is_setproperties and true for missingis_not_setproperties.This change returns
InconclusiveMatchErrorwhen either presence operator's key is omitted. Present keys remain conclusive, including null and other falsey values.💚 How did you test it?
cargo fmt --all -- --checkcargo test --lib test_is_set_operatorcargo test --lib test_is_not_set_operatorcargo test --lib(231 tests passed)📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi coding agent worker subagents implemented and validated the focused matcher change. The bundled autoreview tool reviewed the final committed diff against
origin/main.