[DanielVisca]

Adds framework-agnostic request instrumentation to posthog-node for fetch-API servers (Hono, Bun, Deno, Next route handlers, Workers), which previously only had Express/NestJS support.

• instrumentRequest(posthog, request, handler, options?): reads x-posthog-session-id / distinct id into withContext, opens a server span continuing traceparent, renames it to the matched route, marks 5xx and thrown errors as errors, and records http.server.request.duration (seconds histogram) and http.server.request.count.
• posthogHonoMiddleware(posthog, options?): the same for Hono, with no hono dependency.

Why: SDK-003 in https://github.com/PostHog/dash/blob/main/docs/POSTHOG_SDK_FEEDBACK.md (Dash had to hand-write this in ~25 lines).

Status: draft; tests, lint and typecheck still to run.

🤖 Generated with Claude Code

[github-actions]

Coherence

📄 0 spec file errors · ⛔ 0 broken rules · 🚪 2 unchecked inputs · 🐛 0 bugs that came back

What is Coherence?

Coherence compares the code with its spec files (*.spec.md). A spec file lists the rules for one part of the code.

This check read 44 parts of the code and 7 rules.

Note

These findings do not make this check fail.

None of these findings are in files that this pull request changes. You do not need to fix them in this pull request.

🚪 Unchecked inputs (2)

• public api in packages/web/Web.spec.md. The input comes from: host-app.
• webpack plugin in packages/webpack-plugin/Webpack-plugin.spec.md. The input comes from: build.

What this means and how to fix it

Input from outside this code comes in at these places. The spec does not say what checks that input. 10 more places were already like this when Coherence was added. This list does not show them.

To close one of these, find the place by its name in the ## entrances section of its spec file. Add one line under it:

• If all of the input goes through one function that a rule in the spec protects, add guard: <function>.
• If a rule in the spec already checks input from the same source, add the place's name to the entrances: line of that rule.
• If the input needs no check, add control: none - <reason>.

To get the line to add, run npx --no -- coherence scaffold control "<name>".

[github-actions]

Node SDK acceptance v2

Commit: 0bf94d1
Workflow run and artifacts

Capture v0

✅ 83 passed / ❌ 4 non-passing / ⚠️ 954 not selected

Drill-down: run artifacts → node-v2-v0 → acceptance/report.json.diagnostics.json (match case_id below).

❌ server_snapshot_payload_false — failed_assertion

Expected native data result

Code: snapshot_result

Failed step: acceptance/public/evaluate-flags.feature:868

the public snapshot outcomes should have these semantics:

❌ server_snapshot_payload_zero — failed_assertion

Expected native data result

Code: snapshot_result

Failed step: acceptance/public/evaluate-flags.feature:868

the public snapshot outcomes should have these semantics:

❌ server_snapshot_payload_null — failed_assertion

Expected native data result

Code: snapshot_result

Failed step: acceptance/public/evaluate-flags.feature:868

the public snapshot outcomes should have these semantics:

❌ migration/yaml-parity-v1/remote-flags-v1.feature::Omitted GeoIP settings default to enabled in flag requests — failed_assertion

Flags field differs

Code: flag_request_field

Failed step: migration/yaml-parity-v1/remote-flags-v1.feature:134

the first flags request field "geoip_disable" should equal JSON false

Operation: /flags/

Field: geoip_disable

Expected:

false

Actual value:

true

Harness exit: 1; report validation exit: 1.

Capture v1

✅ 148 passed / ❌ 4 non-passing / ⚠️ 889 not selected

Drill-down: run artifacts → node-v2-v1 → acceptance/report.json.diagnostics.json (match case_id below).

❌ server_snapshot_payload_false — failed_assertion

Expected native data result

Code: snapshot_result

Failed step: acceptance/public/evaluate-flags.feature:868

the public snapshot outcomes should have these semantics:

❌ server_snapshot_payload_zero — failed_assertion

Expected native data result

Code: snapshot_result

Failed step: acceptance/public/evaluate-flags.feature:868

the public snapshot outcomes should have these semantics:

❌ server_snapshot_payload_null — failed_assertion

Expected native data result

Code: snapshot_result

Failed step: acceptance/public/evaluate-flags.feature:868

the public snapshot outcomes should have these semantics:

❌ migration/yaml-parity-v1/remote-flags-v1.feature::Omitted GeoIP settings default to enabled in flag requests — failed_assertion

Flags field differs

Code: flag_request_field

Failed step: migration/yaml-parity-v1/remote-flags-v1.feature:134

the first flags request field "geoip_disable" should equal JSON false

Operation: /flags/

Field: geoip_disable

Expected:

false

Actual value:

true

Harness exit: 1; report validation exit: 1.

[github-actions]

SDK performance: posthog-node

2 changes worth reviewing: 1 observed improvement, 1 observed regression.

Flags require at least a 5% change in the median and all six pairs agreeing on direction. This is a noise filter, not proof of a performance change or a CI gate.

Test	Measurement	Before PR	With PR	Change
Capture and deliver events (32-byte payload, steady)	Allocated memory per operation (estimated)	10.81 KiB/op	9.62 KiB/op	11.1% less memory
Capture and deliver events (4,096-byte payload, burst)	Allocated memory per operation (estimated)	17.55 KiB/op	18.62 KiB/op	6.1% more memory

View all results

Test	Measurement	Before PR	With PR	Change	Assessment
Capture and deliver events (32-byte payload, burst) Shard: capture	Allocations per operation	—	—	—	unavailable; base:​ unsupported; head:​ unsupported; base:​ V8 samples do not expose total allocation count; sample count is not object count.​; head:​ V8 samples do not expose total allocation count; sample count is not object count.​
Capture and deliver events (4,096-byte payload, burst) Shard: capture	Allocations per operation	—	—	—	unavailable; base:​ unsupported; head:​ unsupported; base:​ V8 samples do not expose total allocation count; sample count is not object count.​; head:​ V8 samples do not expose total allocation count; sample count is not object count.​
Capture and deliver events (32-byte payload, steady) Shard: capture	Allocations per operation	—	—	—	unavailable; base:​ unsupported; head:​ unsupported; base:​ V8 samples do not expose total allocation count; sample count is not object count.​; head:​ V8 samples do not expose total allocation count; sample count is not object count.​
Capture and deliver events (4,096-byte payload, steady) Shard: capture	Allocations per operation	—	—	—	unavailable; base:​ unsupported; head:​ unsupported; base:​ V8 samples do not expose total allocation count; sample count is not object count.​; head:​ V8 samples do not expose total allocation count; sample count is not object count.​
Queue an event (32-byte payload) Shard: capture	Allocations per operation	—	—	—	unavailable; base:​ unsupported; head:​ unsupported; base:​ V8 samples do not expose total allocation count; sample count is not object count.​; head:​ V8 samples do not expose total allocation count; sample count is not object count.​
Queue an event (4,096-byte payload) Shard: capture	Allocations per operation	—	—	—	unavailable; base:​ unsupported; head:​ unsupported; base:​ V8 samples do not expose total allocation count; sample count is not object count.​; head:​ V8 samples do not expose total allocation count; sample count is not object count.​
Evaluate all 10 flags Shard: flags-scaling	Allocations per operation	—	—	—	unavailable; base:​ unsupported; head:​ unsupported; base:​ V8 samples do not expose total allocation count; sample count is not object count.​; head:​ V8 samples do not expose total allocation count; sample count is not object count.​
Evaluate all 100 flags Shard: flags-scaling	Allocations per operation	—	—	—	unavailable; base:​ unsupported; head:​ unsupported; base:​ V8 samples do not expose total allocation count; sample count is not object count.​; head:​ V8 samples do not expose total allocation count; sample count is not object count.​
Evaluate all 1,000 flags Shard: flags-scaling	Allocations per operation	—	—	—	unavailable; base:​ unsupported; head:​ unsupported; base:​ V8 samples do not expose total allocation count; sample count is not object count.​; head:​ V8 samples do not expose total allocation count; sample count is not object count.​
Evaluate one boolean flag Shard: flags-single	Allocations per operation	—	—	—	unavailable; base:​ unsupported; head:​ unsupported; base:​ V8 samples do not expose total allocation count; sample count is not object count.​; head:​ V8 samples do not expose total allocation count; sample count is not object count.​
Evaluate a cohort-filtered flag Shard: flags-single	Allocations per operation	—	—	—	unavailable; base:​ unsupported; head:​ unsupported; base:​ V8 samples do not expose total allocation count; sample count is not object count.​; head:​ V8 samples do not expose total allocation count; sample count is not object count.​
Evaluate a flag (early match) Shard: flags-single	Allocations per operation	—	—	—	unavailable; base:​ unsupported; head:​ unsupported; base:​ V8 samples do not expose total allocation count; sample count is not object count.​; head:​ V8 samples do not expose total allocation count; sample count is not object count.​
Evaluate a flag (late match) Shard: flags-single	Allocations per operation	—	—	—	unavailable; base:​ unsupported; head:​ unsupported; base:​ V8 samples do not expose total allocation count; sample count is not object count.​; head:​ V8 samples do not expose total allocation count; sample count is not object count.​
Evaluate a flag (no match) Shard: flags-single	Allocations per operation	—	—	—	unavailable; base:​ unsupported; head:​ unsupported; base:​ V8 samples do not expose total allocation count; sample count is not object count.​; head:​ V8 samples do not expose total allocation count; sample count is not object count.​
Evaluate a property-filtered flag Shard: flags-single	Allocations per operation	—	—	—	unavailable; base:​ unsupported; head:​ unsupported; base:​ V8 samples do not expose total allocation count; sample count is not object count.​; head:​ V8 samples do not expose total allocation count; sample count is not object count.​
Evaluate a regex-filtered flag Shard: flags-single	Allocations per operation	—	—	—	unavailable; base:​ unsupported; head:​ unsupported; base:​ V8 samples do not expose total allocation count; sample count is not object count.​; head:​ V8 samples do not expose total allocation count; sample count is not object count.​
Evaluate a rollout flag Shard: flags-single	Allocations per operation	—	—	—	unavailable; base:​ unsupported; head:​ unsupported; base:​ V8 samples do not expose total allocation count; sample count is not object count.​; head:​ V8 samples do not expose total allocation count; sample count is not object count.​
Evaluate a multivariate flag Shard: flags-single	Allocations per operation	—	—	—	unavailable; base:​ unsupported; head:​ unsupported; base:​ V8 samples do not expose total allocation count; sample count is not object count.​; head:​ V8 samples do not expose total allocation count; sample count is not object count.​
Capture and deliver events (32-byte payload, burst) Shard: capture	Allocated memory per operation (estimated)	10.26 KiB/op	10.27 KiB/op	<0.1% more memory	Not flagged
Capture and deliver events (32-byte payload, burst) Shard: capture	Time per operation	11.34 µs/op	11.41 µs/op	0.5% more time	Not flagged
Capture and deliver events (32-byte payload, burst) Shard: capture	Idle process memory (RSS)	102.71 MiB	102.82 MiB	0.1% more memory	Not flagged
Capture and deliver events (32-byte payload, burst) Shard: capture	Observed peak process memory (RSS)	106.18 MiB	106.47 MiB	0.3% more memory	Not flagged
Capture and deliver events (32-byte payload, burst) Shard: capture	Managed heap after settling	9.97 MiB	9.99 MiB	0.2% more memory	Not flagged
Capture and deliver events (32-byte payload, burst) Shard: capture	Process memory after settling (RSS)	105.88 MiB	106.17 MiB	0.3% more memory	Not flagged
Capture and deliver events (32-byte payload, burst) Shard: capture	Process CPU time per operation	21.12 µs/op	21.14 µs/op	<0.1% more time	Not flagged
Capture and deliver events (32-byte payload, burst) Shard: capture	Lifetime peak process memory (RSS)	106.39 MiB	106.73 MiB	0.3% more memory	Not flagged
Capture and deliver events (4,096-byte payload, burst) Shard: capture	Allocated memory per operation (estimated)	17.55 KiB/op	18.62 KiB/op	6.1% more memory	Worth reviewing: observed regression
Capture and deliver events (4,096-byte payload, burst) Shard: capture	Time per operation	21.08 µs/op	20.5 µs/op	2.7% less time	Not flagged
Capture and deliver events (4,096-byte payload, burst) Shard: capture	Idle process memory (RSS)	103.32 MiB	103.25 MiB	<0.1% less memory	Not flagged
Capture and deliver events (4,096-byte payload, burst) Shard: capture	Observed peak process memory (RSS)	113.8 MiB	113.76 MiB	<0.1% less memory	Not flagged
Capture and deliver events (4,096-byte payload, burst) Shard: capture	Managed heap after settling	9.98 MiB	10 MiB	0.2% more memory	Not flagged
Capture and deliver events (4,096-byte payload, burst) Shard: capture	Process memory after settling (RSS)	109.67 MiB	109.66 MiB	<0.1% less memory	Not flagged
Capture and deliver events (4,096-byte payload, burst) Shard: capture	Process CPU time per operation	31.4 µs/op	30.52 µs/op	2.8% less time	Not flagged
Capture and deliver events (4,096-byte payload, burst) Shard: capture	Lifetime peak process memory (RSS)	116.6 MiB	116.59 MiB	<0.1% less memory	Not flagged
Capture and deliver events (32-byte payload, steady) Shard: capture	Allocated memory per operation (estimated)	10.81 KiB/op	9.62 KiB/op	11.1% less memory	Worth reviewing: observed improvement
Capture and deliver events (32-byte payload, steady) Shard: capture	Time per operation	12.01 µs/op	12.31 µs/op	2.4% more time	Not flagged
Capture and deliver events (32-byte payload, steady) Shard: capture	Idle process memory (RSS)	102.57 MiB	102.47 MiB	<0.1% less memory	Not flagged
Capture and deliver events (32-byte payload, steady) Shard: capture	Observed peak process memory (RSS)	106.76 MiB	106.93 MiB	0.2% more memory	Not flagged
Capture and deliver events (32-byte payload, steady) Shard: capture	Managed heap after settling	10.05 MiB	10.07 MiB	0.2% more memory	Not flagged
Capture and deliver events (32-byte payload, steady) Shard: capture	Process memory after settling (RSS)	106.76 MiB	106.68 MiB	<0.1% less memory	Not flagged
Capture and deliver events (32-byte payload, steady) Shard: capture	Process CPU time per operation	21.81 µs/op	22.17 µs/op	1.6% more time	Not flagged
Capture and deliver events (32-byte payload, steady) Shard: capture	Lifetime peak process memory (RSS)	106.98 MiB	106.93 MiB	<0.1% less memory	Not flagged
Capture and deliver events (4,096-byte payload, steady) Shard: capture	Allocated memory per operation (estimated)	18.15 KiB/op	18.02 KiB/op	0.7% less memory	Not flagged
Capture and deliver events (4,096-byte payload, steady) Shard: capture	Time per operation	17.77 µs/op	17.68 µs/op	0.5% less time	Not flagged
Capture and deliver events (4,096-byte payload, steady) Shard: capture	Idle process memory (RSS)	102.83 MiB	102.87 MiB	<0.1% more memory	Not flagged
Capture and deliver events (4,096-byte payload, steady) Shard: capture	Observed peak process memory (RSS)	109.71 MiB	109.44 MiB	0.2% less memory	Not flagged
Capture and deliver events (4,096-byte payload, steady) Shard: capture	Managed heap after settling	10.06 MiB	10.07 MiB	0.2% more memory	Not flagged
Capture and deliver events (4,096-byte payload, steady) Shard: capture	Process memory after settling (RSS)	108.39 MiB	107.98 MiB	0.4% less memory	Not flagged
Capture and deliver events (4,096-byte payload, steady) Shard: capture	Process CPU time per operation	28.27 µs/op	28.08 µs/op	0.7% less time	Not flagged
Capture and deliver events (4,096-byte payload, steady) Shard: capture	Lifetime peak process memory (RSS)	109.71 MiB	109.44 MiB	0.2% less memory	Not flagged
Queue an event (32-byte payload) Shard: capture	Allocated memory per operation (estimated)	8.71 KiB/op	8.67 KiB/op	0.4% less memory	Not flagged
Queue an event (32-byte payload) Shard: capture	Time per operation	8.46 µs/op	8.1 µs/op	4.3% less time	Not flagged
Queue an event (32-byte payload) Shard: capture	Process CPU time per operation	16.58 µs/op	16.03 µs/op	3.3% less time	Not flagged
Queue an event (4,096-byte payload) Shard: capture	Allocated memory per operation (estimated)	8.83 KiB/op	8.7 KiB/op	1.4% less memory	Not flagged
Queue an event (4,096-byte payload) Shard: capture	Time per operation	8.13 µs/op	8.53 µs/op	4.9% more time	Not flagged
Queue an event (4,096-byte payload) Shard: capture	Process CPU time per operation	16.17 µs/op	17.16 µs/op	6.1% more time	Not flagged
Evaluate all 10 flags Shard: flags-scaling	Allocated memory per operation (estimated)	133.77 KiB/op	133.63 KiB/op	0.1% less memory	Not flagged
Evaluate all 10 flags Shard: flags-scaling	Time per operation	255.1 µs/op	254.09 µs/op	0.4% less time	Not flagged
Evaluate all 10 flags Shard: flags-scaling	Process CPU time per operation	390.49 µs/op	386.78 µs/op	1% less time	Not flagged
Evaluate all 100 flags Shard: flags-scaling	Allocated memory per operation (estimated)	1.23 MiB/op	1.22 MiB/op	0.9% less memory	Not flagged
Evaluate all 100 flags Shard: flags-scaling	Time per operation	2.22 ms/op	2.22 ms/op	0.4% more time	Not flagged
Evaluate all 100 flags Shard: flags-scaling	Process CPU time per operation	3.2 ms/op	3.25 ms/op	1.4% more time	Not flagged
Evaluate all 1,000 flags Shard: flags-scaling	Allocated memory per operation (estimated)	12.11 MiB/op	12.1 MiB/op	0.1% less memory	Not flagged
Evaluate all 1,000 flags Shard: flags-scaling	Time per operation	23.95 ms/op	24.23 ms/op	1.2% more time	Not flagged
Evaluate all 1,000 flags Shard: flags-scaling	Process CPU time per operation	33.05 ms/op	33.14 ms/op	0.3% more time	Not flagged
Evaluate 1,000 flags under concurrent load Shard: flags-memory	Idle process memory (RSS)	272.87 MiB	273.38 MiB	0.2% more memory	Not flagged
Evaluate 1,000 flags under concurrent load Shard: flags-memory	Observed peak process memory (RSS)	273 MiB	273.38 MiB	0.1% more memory	Not flagged
Evaluate 1,000 flags under concurrent load Shard: flags-memory	Managed heap after settling	9.63 MiB	9.63 MiB	<0.1% more memory	Not flagged
Evaluate 1,000 flags under concurrent load Shard: flags-memory	Process memory after settling (RSS)	272.47 MiB	273.02 MiB	0.2% more memory	Not flagged
Evaluate 1,000 flags under concurrent load Shard: flags-memory	Lifetime peak process memory (RSS)	273.91 MiB	274.43 MiB	0.2% more memory	Not flagged
Refresh 1,000 flag definitions Shard: flags-memory	Idle process memory (RSS)	227.08 MiB	227.49 MiB	0.2% more memory	Not flagged
Refresh 1,000 flag definitions Shard: flags-memory	Observed peak process memory (RSS)	239.98 MiB	239.65 MiB	0.1% less memory	Not flagged
Refresh 1,000 flag definitions Shard: flags-memory	Managed heap after settling	11.63 MiB	11.65 MiB	0.1% more memory	Not flagged
Refresh 1,000 flag definitions Shard: flags-memory	Process memory after settling (RSS)	235.63 MiB	235.41 MiB	<0.1% less memory	Not flagged
Refresh 1,000 flag definitions Shard: flags-memory	Lifetime peak process memory (RSS)	241.62 MiB	242.06 MiB	0.2% more memory	Not flagged
Evaluate one boolean flag Shard: flags-single	Allocated memory per operation (estimated)	17.16 KiB/op	17.17 KiB/op	0.1% more memory	Not flagged
Evaluate one boolean flag Shard: flags-single	Time per operation	72.71 µs/op	72.53 µs/op	0.2% less time	Not flagged
Evaluate one boolean flag Shard: flags-single	Process CPU time per operation	70.8 µs/op	70.5 µs/op	0.4% less time	Not flagged
Evaluate a cohort-filtered flag Shard: flags-single	Allocated memory per operation (estimated)	14.09 KiB/op	14.15 KiB/op	0.4% more memory	Not flagged
Evaluate a cohort-filtered flag Shard: flags-single	Time per operation	42.37 µs/op	41.04 µs/op	3.1% less time	Not flagged
Evaluate a cohort-filtered flag Shard: flags-single	Process CPU time per operation	45.63 µs/op	43.96 µs/op	3.7% less time	Not flagged
Evaluate a flag (early match) Shard: flags-single	Allocated memory per operation (estimated)	17.71 KiB/op	17.57 KiB/op	0.8% less memory	Not flagged
Evaluate a flag (early match) Shard: flags-single	Time per operation	44.12 µs/op	42.33 µs/op	4% less time	Not flagged
Evaluate a flag (early match) Shard: flags-single	Process CPU time per operation	47.01 µs/op	44.88 µs/op	4.5% less time	Not flagged
Evaluate a flag (late match) Shard: flags-single	Allocated memory per operation (estimated)	22.48 KiB/op	22.35 KiB/op	0.6% less memory	Not flagged
Evaluate a flag (late match) Shard: flags-single	Time per operation	45.32 µs/op	44.37 µs/op	2.1% less time	Not flagged
Evaluate a flag (late match) Shard: flags-single	Process CPU time per operation	48.24 µs/op	47.11 µs/op	2.4% less time	Not flagged
Evaluate a flag (no match) Shard: flags-single	Allocated memory per operation (estimated)	16.93 KiB/op	16.89 KiB/op	0.2% less memory	Not flagged
Evaluate a flag (no match) Shard: flags-single	Time per operation	6.12 µs/op	5.93 µs/op	3.1% less time	Not flagged
Evaluate a flag (no match) Shard: flags-single	Process CPU time per operation	10.48 µs/op	10.44 µs/op	0.4% less time	Not flagged
Evaluate a property-filtered flag Shard: flags-single	Allocated memory per operation (estimated)	12.57 KiB/op	12.71 KiB/op	1.1% more memory	Not flagged
Evaluate a property-filtered flag Shard: flags-single	Time per operation	40.64 µs/op	39.83 µs/op	2% less time	Not flagged
Evaluate a property-filtered flag Shard: flags-single	Process CPU time per operation	42.64 µs/op	41.5 µs/op	2.7% less time	Not flagged
Evaluate a regex-filtered flag Shard: flags-single	Allocated memory per operation (estimated)	18.32 KiB/op	18.37 KiB/op	0.3% more memory	Not flagged
Evaluate a regex-filtered flag Shard: flags-single	Time per operation	75.55 µs/op	77.4 µs/op	2.4% more time	Not flagged
Evaluate a regex-filtered flag Shard: flags-single	Process CPU time per operation	74.63 µs/op	76.28 µs/op	2.2% more time	Not flagged
Evaluate a rollout flag Shard: flags-single	Allocated memory per operation (estimated)	14.27 KiB/op	14.21 KiB/op	0.4% less memory	Not flagged
Evaluate a rollout flag Shard: flags-single	Time per operation	56.23 µs/op	55.64 µs/op	1.1% less time	Not flagged
Evaluate a rollout flag Shard: flags-single	Process CPU time per operation	56.04 µs/op	54.98 µs/op	1.9% less time	Not flagged
Evaluate a multivariate flag Shard: flags-single	Allocated memory per operation (estimated)	17.37 KiB/op	17.49 KiB/op	0.7% more memory	Not flagged
Evaluate a multivariate flag Shard: flags-single	Time per operation	73.12 µs/op	73.04 µs/op	0.1% less time	Not flagged
Evaluate a multivariate flag Shard: flags-single	Process CPU time per operation	71.61 µs/op	71.45 µs/op	0.2% less time	Not flagged

Values are medians of paired measurements. Not flagged does not mean unchanged. Unavailable means a measurement could not be provided, not zero. Estimated allocation measurements retain their instrumentation uncertainty. RSS measures the whole process, not just SDK allocations; observed peaks are sampled checkpoints. Paired ranges in the diagnostics describe variability, not confidence intervals.

Each shard uses its own runner; compare Before PR against With PR within a row, not across shards.

Compared a0e648577347a0e36c1956fecc66f31623f96f9e → 0bf94d17de5e979b39bb0cdc32068dbdffcb1bf2.

Full report and diagnostics

102 metric rows; 102 rows shown in all results. Omitted or shortened data remain in comparison.json, including per-runner environments, resource limits, measurement methods, samples and checkpoints.