fix(flags): align presence operator semantics - #4651
Merged
Conversation
Contributor
posthog-node Compliance ReportDate: 2026-08-27 04:54:48 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
Contributor
Contributor
posthog-js Compliance ReportDate: 2026-08-27 05:01:51 UTC ✅ All Tests Passed!26/26 tests passed Capture Tests✅ 26/26 tests passed View Details
|
Contributor
|
Size Change: +126 B (0%) Total Size: 20.3 MB 📦 View Changed
ℹ️ View Unchanged
|
marandaneto
marked this pull request as ready for review
August 26, 2026 10:00
posthog-project-board-bot
Bot
moved this from In Progress
to In Review
in Feature Flags
Contributor
|
Reviews (1): Last reviewed commit: "fix(flags): preserve fallback after inco..." | Re-trigger Greptile |
ioannisj
approved these changes
Aug 26, 2026
marandaneto
enabled auto-merge (squash)
August 26, 2026 15:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sdk-specs PR #49 defines omitted properties as inconclusive because SDK property maps contain partial context. The shared local evaluator treated an omitted key as matching
is_not_set. That could produce a local result that disagrees with stored PostHog properties and remote evaluation.Changes
InconclusiveMatchErrorforis_not_set, matching existingis_setbehavior.early_exitrollout exclusion.Validated with:
pnpm --filter @posthog/core exec jest --runInBand src/__tests__/featureFlagLocalEvaluation.spec.tspnpm --filter posthog-node exec jest --runInBand src/__tests__/feature-flags.spec.tsgit diff --check4c709e522with no actionable findingsRelease info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi coding agent worker subagents implemented the shared matcher change and its package-level tests. The bundled autoreview tool reviewed the final committed diff against
origin/main.