fix(flags): align presence operator semantics - #733
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "fix(flags): use group type properties fo..." | Re-trigger Greptile |
ioannisj
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
sdk-specs PR #49 defines presence operators using property-key presence and partial property context. The
posthog-serverevaluator treated a present null value as not set and could not resolveis_not_setwhen the key was present.This change makes every present key match
is_setand not matchis_not_set, including null and other falsey values. An omitted key remains inconclusive so remote evaluation stays eligible. Group flags now select the property map for their matching group type before applying the same rules.💚 How did you test it?
./gradlew :posthog-server:test --tests "com.posthog.server.internal.FlagEvaluatorTest"./gradlew :posthog-server:test --tests "com.posthog.server.internal.PostHogFeatureFlagsTest"./gradlew spotlessCheck6811c125with no actionable findings.📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi coding agent worker subagents implemented and validated the focused
posthog-serverchange. The bundled autoreview tool reviewed the final committed diff againstorigin/main.