fix: persist settings on exit and watch every keyboard#2
Open
Austin-Metke wants to merge 1 commit into
Open
Conversation
Drop the per-app winxp OSVersion override. It was added to dodge a Save dialog crash under older Wine, but it also disabled the WinForms FormClosing event chain, so RecentSplits, RecentLayouts, window size, and GlobalHotkeysEnabled never persisted on exit. Newer Wine handles IFileDialog correctly, so the workaround is obsolete; Run.sh now strips any leftover override on launch instead of installing one. Enumerate every *-event-kbd device under /dev/input/by-path/ instead of taking only the first match, deduped by resolved real path (the same USB keyboard appears under both -usb- and -usbv2- aliases). Fixes global hotkeys for setups with multiple keyboards where the primary one isn't first in the by-path listing. Also extends WINEDLLOVERRIDES with gdiplus, winhttp, and msxml6 native-then-builtin, and shortens the bridge startup delay from 4s to 1s. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
winxpOSVersion override. It was added to fix a Save dialog crash under older Wine, but it also disables the WinFormsFormClosingevent chain — which is why nothing written on app exit (RecentSplits, RecentLayouts, window size,GlobalHotkeysEnabled) was persisting. Verified with currentwine.AppImage: Save Splits/Layout As work fine without the override, and on-close persistence is restored.Run.shnow strips any leftover override on launch instead of installing one.ls /dev/input/by-path/*-event-kbd | head -n 1approach only fed the bridge the first keyboard, so global hotkeys silently failed for users typing on a different one. Now enumerates all*-event-kbdentries and dedupes by resolved real path (each USB keyboard appears under both-usb-and-usbv2-aliases).WINEDLLOVERRIDESwithgdiplus,winhttp, andmsxml6set to native-then-builtin, and shortens the bridge startup delay from 4s → 1s.Test plan
GlobalHotkeysEnabled=Truesurvives closeRecentSplits/RecentLayoutspopulate afterFile → Open Splits/Save Splits Asand survive restartFile → Save LayoutFile → Save Splits As…andFile → Save Layout As…no longer crashRun.shpassesbash -nsyntax check🤖 Generated with Claude Code