[Communication v2] PR1: Tied Mailbox to CommsManager

[Joseph0120]

No description provided.

[gemini-code-assist]

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

[coderabbitai]

Warning

Review limit reached

@Joseph0120, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c4a64f0b-3758-4d34-8863-e07d0283f4e2

📥 Commits

Reviewing files that changed from the base of the PR and between a325ce1 and 997f01d.

📒 Files selected for processing (2)

• Assets/Scripts/Communication/Mailbox.cs
• Assets/Scripts/Managers/CommsManager.cs

📝 Walkthrough

Walkthrough

Adds a singleton Unity mailbox that validates endpoints, schedules messages with configurable delivery ratios, latency, and jitter, drops packets probabilistically, and delivers due messages. CommsManager constructs and updates the mailbox, clears pending messages during simulation lifecycle events, and exposes node membership checks. PriorityQueue gains queue clearing support, and a new solution definition lists the project files.

Estimated code review effort: 4 (Complex) | ~45 minutes

Possibly related PRs

• PisterLab/micromissiles-unity#212: Introduces messaging contract types used by the mailbox queue and delivery logic.
• PisterLab/micromissiles-unity#213: Adds communication models and agents that interoperate with the mailbox system.
• PisterLab/micromissiles-unity#234: Modifies communication-node and mailbox compatibility around node validation and manager integration.

Suggested reviewers: tryuan99

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No description was provided, so there isn't enough content to assess beyond the PR context.	Add a brief description of the communication and mailbox changes so reviewers can validate the intent.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: wiring Mailbox into CommsManager.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch joseph/communication_v2

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Assets/Scripts/Managers/CommsManager.cs`:
- Around line 44-46: Update CommsManager.FixedUpdate to invoke UpdateMailbox
through the existing _mailbox reference instead of Mailbox.Instance, and
preserve safe behavior by checking _mailbox for null before calling it.
- Around line 28-42: Update CommsManager.Start and OnDestroy to symmetrically
manage all five SimManager subscriptions. Replace the anonymous
OnSimulationEnded lambda that clears _nodes with a named handler or stored
delegate, then unsubscribe it alongside _mailbox.ClearPendingMessageQueue,
RegisterNewAgent for OnNewInterceptor, and RegisterNewAgent for OnNewLauncher
during destruction.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e4dff7fe-1de3-41fc-bd94-336f77699007

📥 Commits

Reviewing files that changed from the base of the PR and between 499402c and a325ce1.

📒 Files selected for processing (5)

• Assets/Scripts/Communication/Mailbox.cs
• Assets/Scripts/Communication/Mailbox.cs.meta
• Assets/Scripts/Managers/CommsManager.cs
• Assets/Scripts/Utils/PriorityQueue.cs
• Pisterlab_Micromissile.slnx