Skip to content

Replace sl-tab with ha-tab in editor component - #40

Merged
PiotrMachowski merged 1 commit into
PiotrMachowski:devfrom
lennon101:patch-1
Oct 28, 2025
Merged

PiotrMachowski merged 1 commit into
PiotrMachowski:devfrom
lennon101:patch-1

Conversation

@lennon101

Copy link
Copy Markdown
Contributor

Tested and confirmed as working in my own instance of this repo

Tested and confirmed as working in my own instance of this repo
@lennon101

Copy link
Copy Markdown
Contributor Author

This resolves issue #39. Discovery of the fix was via commit number 522508f in the layout-card that resolved a similar issue

@lennon101

Copy link
Copy Markdown
Contributor Author

not entirely sure why the Validate HACS Action failed. I'm guessing it's because my project directory hasn't been built correctly (probably because my own repo Actions aren't running correctly). I'm not very knowledgeable with the how the github actions works so if this is something MUST pass before the pull request can be merged please let me know and if anyone can help me fix it that would be great!

@PiotrMachowski

Copy link
Copy Markdown
Owner

Don't worry about HACS check, build action is the one that matters

@PiotrMachowski
PiotrMachowski changed the base branch from master to dev October 28, 2025 03:49
@PiotrMachowski
PiotrMachowski merged commit 7d482e9 into PiotrMachowski:dev Oct 28, 2025
1 of 2 checks passed
@PiotrMachowski

Copy link
Copy Markdown
Owner

Thanks, @lennon101!

There are still some issues though, I will try to adjust them on the dev branch

@lennon101

Copy link
Copy Markdown
Contributor Author

yeah amazing! out of pure interest, what were the other issues? Thanks for merging and fixing! This is a great project!

@PiotrMachowski

PiotrMachowski commented Oct 28, 2025 •

Copy link
Copy Markdown
Owner

Things that has to be done:

  • mwc-button has to be migrated to ha-button ✅
  • card picker doesn't render when editing the card (after first page load) ❌

@PiotrMachowski

Copy link
Copy Markdown
Owner

@lennon101 I have fixed the first problem at dev branch, but at this moment I don't have time to try with the second one (potential quick fixes were unsuccessful). You can check it out if you want to ;)

@PiotrMachowski

Copy link
Copy Markdown
Owner

I've implemented the missing part, v2.1.4 has been released

@lennon101

Copy link
Copy Markdown
Contributor Author

I've implemented the missing part, v2.1.4 has been released

yeah thanks mate! I had a look but wasn't sure how to implement that missing part. Thanks for getting it done!

@PiotrMachowski

Copy link
Copy Markdown
Owner

Well, I have also stolen it from layout-card 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants