Skip to content

Improve input unit flexibility in TEDFs #15

Description

@clarabachorz

Some sources for the processes Methanol to Olefins and Naphtha Steam Cracking report functional units from simulations that can be given as kg/s instead of kg, for example. This is then reported relative to the product output, also in kg/s. However, unit_convert does not support such entries, raising that kg/s cannot be converted to kg.
Additionally, such unit conversion issues are not caught with Exceptions, making it hard to identify the row affected.

Suggested Fixes:

  • add another step in unit conversion, which first simplifies the reported units for unit and reference_unit relative to one another (ie. here, convert kg/s to kg for both entries).
  • add Exceptions that can catch such unit conversion issues

Activity

  1. PhilippVerpoort commented on May 23, 2024

    @PhilippVerpoort
    Owner

    Is it possible, by any chance, to report these as Input Capacity per Output Capacity? At least I think, posted shouldn't complain about the dimensionality of the units, at first. I think it should then be possible to create a variable mapping for those entries.

    And I agree that there should be exceptions warning users about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

enhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions