Pie chart pretty gradients#3764
Open
huntj88 wants to merge 4 commits intoPhilJay:masterfrom
Open
Conversation
Author
|
I also would like to implement choosing a second color optionally. I have already done this on my local computer, but I don't plan on pushing that because it doesn't really conform to how you set colors in the rest of the library. Heres a screenshot with subtle color differences
do you have any ideas about what that might look like? |
huntj88
commented
Jan 30, 2018
| float[] positions = {0, sliceAngle / 360f}; | ||
| SweepGradient sweepGradient = new SweepGradient(center.x, center.y, colors, positions); | ||
|
|
||
| //rotate gradient so it doesn't start or the right side (0 degrees) |
| int secondColor = Color.rgb(red, green, blue); | ||
|
|
||
| int[] colors = new int[2]; | ||
| colors[0] = mRenderPaint.getColor(); |
Contributor
|
Hey, this looks nice! I like the ability to have a gradient effect. Could you create a new pull request, with just the dual color option, so that setting the first color creates a solid color slice, and setting a second enables the gradient for the slice. I will gladly merge it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made the pie charts use a gradient optionally.
it takes the current color and computes a slightly darker color to use for the second color in the gradient