close #1041 Refactor preference handling to use type-safe enums and constant keys.#1479
Draft
chaneylc wants to merge 1 commit into
Draft
close #1041 Refactor preference handling to use type-safe enums and constant keys.#1479chaneylc wants to merge 1 commit into
chaneylc wants to merge 1 commit into
Conversation
Refactor preference handling to use type-safe enums and constant keys. Specific changes include: - Replaced hardcoded string values with specialized enums for `TransferSource`, `LocationCollectionMode`, `GeoNavLoggingMode`, `AppThemeType`, `SkipEntriesMode`, and `MoveToUniqueIdMode`. - Migrated manual index-to-enum logic in `ThemeViewModel` and `ThemedActivity` to centralized `fromIndex` and `fromValue` helper methods. - Standardized default preference values across `CollectActivity`, `GeoNavHelper`, and various preference fragments. - Updated `LocationPreferencesFragment` to dynamically manage UI visibility based on enum-driven logic. - Improved readability in `RangeBoxView` by replacing magic numbers with descriptive enum flags for entry navigation. - Refactored `BrapiFilterCache` to use an enum for cache clear intervals with defined millisecond constants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change Type
ADDITION(non-breaking change that adds functionality)CHANGE(fix or feature that alters existing functionality)FIX(non-breaking change that resolves an issue)OTHER(use only for changes like tooling, build system, CI, docs, etc.)Release Note