Skip to content

fix: verify detached deployments - #50

Merged
PerishCode merged 1 commit into
mainfrom
fix/deploy-wait-state
Jul 10, 2026
Merged

PerishCode merged 1 commit into
mainfrom
fix/deploy-wait-state

Conversation

@PerishCode

Copy link
Copy Markdown
Owner

What changed

  • wait for both detached oneshot completion and the exact target package version
  • fail when the upgrade unit, installed version, service, doctor, memory continuity, or health check is not valid
  • run doctor with the deployed EnvironmentFile so env:// provider credentials resolve without printing them

Why

The beta.24 deploy exposed a race in the old loop: it interpreted the unit's initial inactive state as completion before the queued oneshot entered activating. The wrapper then printed stale schema/service data and still returned success because doctor and health failures were swallowed.

Validation

  • reproduced the premature return against the live beta.24 upgrade
  • manually completed and verified the live deployment: package beta.24, schema 23, service active, health OK, memory unchanged, provider budget 120000
  • deno fmt --config .runseal/deno.json --check .runseal
  • deno lint --config .runseal/deno.json .runseal
  • deno check --config .runseal/deno.json .runseal/wrappers/deploy.ts
  • flavor check

@PerishCode
PerishCode marked this pull request as ready for review July 10, 2026 05:41
@PerishCode
PerishCode merged commit 8839ca8 into main Jul 10, 2026
3 checks passed
@PerishCode
PerishCode deleted the fix/deploy-wait-state branch July 10, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant