Repository navigation
refactor: split receipt printing, settings and app factory - #121
Conversation
Move receipt printing, settings loading and app assembly out of one import-time module into printing.py, settings.py and build_app(). Printer errors always close the connection and reject the message to the dead-letter queue, and blocking I/O runs off the event loop. Drop the unused exchange, DLX and DLQ settings (old config files still load), pin the ack policy, lock the Message wire contract with tests, and add an ADR and GLOSSARY.md. The RabbitMQ payload is unchanged.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78ac5a1f24
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c804280600
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Moves receipt printing, settings loading and app assembly out of one import-time module into
printing.py,settings.pyandbuild_app().~/.croupier.json.GLOSSARY.md.