Add utility functions for writing HDF5 files#73
Open
sebapersson wants to merge 9 commits into
Open
Conversation
sebapersson
requested review from
BSnelling and
dilpath
and removed request for
BSnelling and
dilpath
Collaborator
Author
|
I will update the PR to fit into the existing classes. |
Collaborator
Author
|
I have now revised the PR to use the existing |
BSnelling
approved these changes
May 14, 2026
Collaborator
BSnelling
left a comment
BSnelling
left a comment
There was a problem hiding this comment.
LGTM! Only minor comments.
| array = np.asarray(array) | ||
| except (TypeError, ValueError) as exc: | ||
| raise TypeError( | ||
| "Input array could not be converted to a \ |
Collaborator
There was a problem hiding this comment.
Quoting the type of the input array in the error could be useful.
Co-authored-by: BSnelling <branwen.snelling@crick.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds:
write_input_hdf5: write input arrays to PEtab-SciML HDF5 filewrite_parameter_hdf5: writetorch.NN.moduleto HDF5 fileadd_array_files_to_yaml: helper to add array files to the problem yaml.All functions have associated tests.
See also #11