Repository navigation
feat: added vendorspecific parameters to the specs - #61
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
GetMap tests lack coverage for vendor-parameter round trips and mixed-case standard-key collisions, allowing regressions in parameter preservation and collision protection to pass unnoticed.
1 open issue
What changed in this PR
Adds vendor-specific parameter support to WMS 1.3.0 GetMap requests for use by OGC API Maps.
Changes:
- Preserves vendor parameters during query parsing and serialization.
- Prevents vendor parameters from overriding standard WMS keys, regardless of case.
- Introduces a shared CRS query-key constant and uses it in GetFeatureInfo.
| File | Description |
|---|---|
pkg/wms130/getmap_request.go |
Adds the vendor-parameter field and populates it during parsing. |
pkg/wms130/getmap_request_pv.go |
Parses and serializes vendor parameters while filtering standard-key collisions. |
pkg/wms130/getfeatureinfo_request_pv.go |
Replaces CRS string literals with the shared constant. |
pkg/wms130/common.go |
Defines the shared CRS_KEY constant. |
Review effort: Balanced
mortenzwarenstein
force-pushed
the
feat-vendor-specific-parameters
branch
from
October 29, 2026 10:15
1f44645 to
a913fca
Compare
damienmulder
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
WMS vendor specific parameters for the benefit of ogcapi-maps
Type of change
Checklist: