Release 2.146.1 - #1704
Merged
Merged
Conversation
#1698) img.test.js and eventMapIcons.test.js replaced global.URL.createObjectURL/ revokeObjectURL via direct assignment instead of jest.spyOn, so jest.restoreAllMocks() could never undo it. Since jest-fixed-jsdom binds window.URL to Node's real process-wide singleton, the leaked mock persisted across test files in the same worker, silently accumulating unrelated calls that download.test.js's spy would inherit and misread as its own. Co-authored-by: Alan Calvillo <alanc@earthranger.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: Alan Calvillo <alanc@earthranger.com>
…l values (#1702) * Refactor ReportFormSummary and ReportDetailView to normalize choice list values - Introduced `normalizeChoiceListValues` utility to handle legacy choice list formats in event details. - Updated `EventFormSummary` to utilize normalized form data for version 2 schema. - Modified `DetailsSection` and `ReportDetailView` to pass normalized event details. - Added tests for `normalizeChoiceListValues` to ensure correct transformation of legacy data structures. * Refactor event details handling in ReportFormSummary and ReportManager components - Updated `normalizeChoiceListValues` to accommodate both legacy and current choice list formats. - Modified `EventFormSummary` and `V1SchemaFormSummary` to utilize normalized form data. - Adjusted `DetailsSection` and `ReportDetailView` to ensure consistent event details processing. - Enhanced tests for `normalizeChoiceListValues` to validate handling of various choice list scenarios. * Refactor event details handling in ReportFormSummary and ReportManager components - Simplified the normalization of choice list values across various components. - Updated `EventFormSummary`, `V1SchemaFormSummary`, and `V2SchemaFormSummary` to utilize normalized form data. - Adjusted `DetailsSection` and `ReportDetailView` to consistently process event details. - Enhanced tests for `normalizeChoiceListValues` to validate handling of legacy and current choice list formats. * Refactor normalization of choice list values in SchemaForm and related components - Updated `SchemaForm` to consistently use normalized form data for validation and state management. - Simplified handling of legacy choice list formats across `ReportDetailView` and `V2SchemaFormSummary`. - Enhanced `normalizeChoiceListValues` utility to improve data integrity and processing efficiency. - Adjusted related components to ensure seamless integration of normalized data throughout the application. * Enhance normalization of choice list values across components - Updated `normalizeChoiceListValues` to handle both legacy and current choice list formats more effectively. - Modified `V2SchemaFormSummary`, `ReportDetailView`, and `SchemaForm` to utilize the enhanced normalization logic. - Improved integration of normalized data in event details processing throughout the application. - Expanded tests for `normalizeChoiceListValues` to ensure comprehensive coverage of various scenarios.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
AlanCalvillo
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.