Repository navigation
fix(client): prevent infinite recursion in add access key dialog - #2882
Merged
Merged
Conversation
|
fortuna
reviewed
Oct 7, 2026
Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com>
fortuna
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
RangeError: Maximum call stack size exceededoccurring in theAddAccessKeyDialogcomponent.Root Cause:
The
attributeChangedCallbackinadd-access-key-dialogwas unconditionally callingrunAccessKeyChecks(newValue)for every attribute change. This created an infinite recursion cycle due to:accessKeyproperty havingreflect: true, causing LitElement to reflect property changes back to attributes.md-filled-text-field.setValidity(triggered by error state changes) synchronously callingsetAttribute, which in turn re-triggeredattributeChangedCallback.Solution:
Introduced a guard in
attributeChangedCallbackto ensurerunAccessKeyChecksis only invoked when theaccesskeyattribute specifically changes. This breaks the recursive cycle. The attribute nameaccesskey(lowercase) is used because Lit 3.x automatically lowercases property names when reflecting to attributes.Tests:
Added a new spec file (
index.spec.ts) to cover the behavior of theattributeChangedCallbackguard, ensuring that:runAccessKeyChecksis called whenaccesskeychanges.runAccessKeyChecksis not called for unrelated attribute changes.accesskeyis changed.Fixes OUTLINE-CLIENTS-NM61S
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry at no cost. You can adjust this setting at any time.