4.6.4 - #1026
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75dc38b5c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| isUrlChanged = false; | ||
| } | ||
| const figWithKey = currentState.freeFigure.find((e) => e.key === key); | ||
| if (figWithKey && figWithKey.name === sentence.content && figWithKey.basePosition === pos && !isBoundsChanged) { |
There was a problem hiding this comment.
Preserve state when only moving a free figure
When an existing free figure is issued again with the same URL and id but a different preset position, this comparison marks it as a new identity. The postFigureStateSet identity-change branch then replaces omitted Live2D motion, skin, expression, bounds, blink/focus, z-index, and blend mode with empty/default values. Consequently, a position-only move unexpectedly discards all previously configured figure state; distinguish the need to recreate the Pixi object from an actual resource replacement and carry the existing state into the recreated object.
Useful? React with 👍 / 👎.
No description provided.