fix(openrouter-models,openrouter-images): surface network/JSON/FS errors cleanly - #128
Open
trippyogi wants to merge 3 commits into
Open
fix(openrouter-models,openrouter-images): surface network/JSON/FS errors cleanly#128trippyogi wants to merge 3 commits into
trippyogi wants to merge 3 commits into
Conversation
…ors cleanly Bare res.json() and unwrapped filesystem calls crashed agents with stack traces on transient failures. Align with the analytics/generations error style (OpenRouterTeam#17).
trippyogi
marked this pull request as ready for review
July 31, 2026 18:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openrouter-modelsandopenrouter-imagesscripts so network failures, non-JSON API bodies, and image filesystem errors print a one-line message and exit 1 instead of an unhandled stack trace.openrouter-analytics/openrouter-generations.Test plan
tsc --strictclean on both modifiedlib.tsfilesreadImageAsDataUrl('does-not-exist.png')prints a cleanCould not read image fileerror and exits 1 (no stack trace)list-models.tsreturns model JSON successfully; imagesdiscover.ts/getImageModelsreturns 38 modelsgenerate.ts "a tiny red dot on white"with a valid key — exit 0, saved ~490KB JPEG viasaveImage(google/gemini-3.1-flash-image-preview)