Use the canonical benchmark harness dependency - #6
Merged
Conversation
git-subtree-dir: packages/bench-harness git-subtree-split: e9801e4ddfd070f30d188ed26ebcda62b3234625
Collaborator
Author
Paid local integration validationValidated the merged Git dependency end to end with an untracked DSQA-only Perplexity TOML: One generation ended without The local TOML and generated result bundle are intentionally untracked and are not part of this PR. |
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The search repository owns a drifting fork of the harness
search-benchmarkscurrently carries a second implementation of@openrouter/bench-harness. Fixes must be ported twice, and downstream-only changes can silently fork prompts, graders, metrics, or persistence. PR #5 exposed this directly: the official DSQA repair landed upstream and also required a separate local rewrite.TL;DR
Delete the local
packages/bench-harnessfork, pin both search applications directly to merged benchmark-harness#11 at immutable commite9801e4, and move repository-specific runner policy intoapps/search-bench-runner. TOML specs, dry-run, cost approval, deterministic resumable chunks, publication, redaction, and viewer behavior remain available; only the runner working directory changes.This PR targets
mainand supersedes the now-closed #5. After merge, theperplexity,parallel, andexabranches should be restacked onto the newmain.What Changed?
One canonical benchmark implementation
packages/bench-harnessentirely.@openrouter/bench-harnessin both app manifests and lockfiles to merged commite9801e4ddfd070f30d188ed26ebcda62b3234625.OpenRouterTeam/benchmark-harness; consumers only bump an immutable SHA.Search benchmark runner boundary
apps/search-bench-runner.@openrouter/bench-harnessexports.000000-000010.parquetsurvive without an upstream patch.Setup
The runner flags and relative spec paths are unchanged; only the working directory moves:
cd apps/search-bench-runner bun install bun run bench -- \ --spec ../../run-specs/example-partner-search.toml \ --run-id example \ --dry-runEach search-benchmarks-owned README links the runner and pinned canonical harness at the top. Root CI validates runner typecheck/tests/dry-run and viewer compatibility. Upstream owns harness format/lint/typecheck/tests/build.
Compatibility and behavior
--allow-harness-changeto resume.2026-07-18) rather than the fork's2025-01-01; this is visible in run provenance and is an intentional consequence of upstream ownership.Validation
Completed locally with Bun 1.3.14:
demo.parquetCLI load passed@openrouter/bench-harnesstoe9801e4in both appsThe merged upstream commit independently passed its format, lint, typecheck, 1,173 tests, build, CodeQL, and CI before this dependency pin.
Sequencing
main.perplexity,parallel, andexaonto the newmain, preserving only engine-specific specs and reviewed result bundles.Reviewer Focus
apps/search-bench-runner.