chore: clean up .gitignore and remove unused output.zip - #596
Open
rajarshidattapy wants to merge 1 commit into
Open
chore: clean up .gitignore and remove unused output.zip#596rajarshidattapy wants to merge 1 commit into
rajarshidattapy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #592, items 1 and 2. Item 3 is answered below but deliberately unchanged, so this
does not auto-close the issue.
Change
output.zip— unreferenced anywhere in the repo;grepacross the tree returns nothing, andits only commit is the Copybara import (
5f2c0ee)..gitignore— checked both directions before removing the two patterns. All four trackedfiles match them (
gen.lock,workflow.lock,in.openapi.yaml,out.openapi.yaml), andgit status --ignoredconfirms the patterns are currently hiding zero untracked files. Soremoving them changes no ignore behaviour; it only stops the file from implying those artifacts
aren't committed here. The neighbouring
.speakeasy/temp/,.speakeasy/logs/, and.speakeasy/reportsrules cover genuinely untracked output and are untouched.Item 3: the
/messagesexclusion — no change, and I'd argue there shouldn't beTwo findings while checking it.
The exclusion is deliberate and owned upstream.
x-speakeasy-ignore: trueis present inin.openapi.yaml, not added by any local overlay — it comes from the monorepo spec. Thatsettles the "worth confirming" question without needing a maintainer.
Given that, both suggested cleanups would be net-negative:
x-speakeasy-name-override: 'create'is not dead weight, it is load-bearing if theexclusion is ever lifted — it is exactly what makes the namespace
client.messages.create.Stripping it via an overlay would sabotage a future un-ignoring.
Anthropic Messagestag produces no artifact: nodocs/sdks/directory, nodocs.jsonnav entry, no SDK class. Removing it would mean adding and maintaining a newoverlay for zero observable change.
One correction to the issue's premise. "We ship the types for an endpoint the client can't
call" isn't accurate. All 8
messages*component modules are consumed bypresets.py—presets.create_presets_messagestakescomponents.MessagesRequest,MessagesMessageParam,MessagesRequestToolUnion,MessagesFallbackParam,MessagesOutputConfigand friends. They serve a callable endpoint; they just are not reachablethrough a
client.messagesnamespace.What remains in item 3 is the product question — should
/messagesbe exposed at all — andthat is a monorepo spec decision rather than something this repo can settle.
Verification
uv buildproduces both sdist and wheeltest_responses_namespace.py::test_responses_namespace_is_ga_and_beta_alias_remains_available,which is Test suite is red on main and CI never runs it: pytest is in neither the dev group nor pr-validation.yaml #585 and already red on
mainbefore this branch.