Gear simulator ssg - #1464
Open
bwdev01 wants to merge 3 commits into
Open
Conversation
agalasso
reviewed
Sep 13, 2026
Comment on lines
+609
to
+610
| bool LoadNonFitsImage(cv::Mat& img, bool preProcess, wxSize& fullSize); | ||
| bool LoadFitsImage(usImage& img, cv::Mat& matImage, bool preProcess, wxSize& fullsize); |
Contributor
There was a problem hiding this comment.
Can we combine these into a single LoadImage method that does everything and remove the filename extension check from the caller (it's duplicated in the method and needn't be done twice).
We can also remove the preProcess argument since it is always true.
| bool LoadFitsImage(usImage& img, cv::Mat& matImage, bool preProcess, wxSize& fullsize); | ||
| void PreProcessImage(cv::Mat& img); | ||
| void GetSimDisplacements(double *pDeltaX, double *pDeltaY, double *pGearTime, bool TransformToCameraCoords); | ||
| bool ApplySimDisplacements(usImage *img, cv::Mat& matImage); |
Contributor
There was a problem hiding this comment.
const since it does not modify matImage
Suggested change
| bool ApplySimDisplacements(usImage *img, cv::Mat& matImage); | |
| bool ApplySimDisplacements(usImage *img, const cv::Mat& matImage); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.