FW: fix issues exposed by codechecker - #256
Draft
Ruben-Lohberg wants to merge 20 commits into
Draft
Conversation
|
Build output available: |
CodeChecker static analysis✅ No non-style issues found. |
|
Build output available: |
Ruben-Lohberg
force-pushed
the
255-fix-issues-exposed-by-codechecker
branch
from
July 27, 2026 14:00
2a83a4d to
fa9f7c5
Compare
|
Build output available: |
|
Build output available: |
Ruben-Lohberg
force-pushed
the
255-fix-issues-exposed-by-codechecker
branch
from
July 27, 2026 14:53
e509194 to
5c96030
Compare
|
Build output available: |
TobiasRoeddiger
marked this pull request as draft
July 31, 2026 09:42
|
Build output available: |
|
Build output available: |
Ruben-Lohberg
force-pushed
the
255-fix-issues-exposed-by-codechecker
branch
from
August 3, 2026 14:49
fc1d581 to
102bf62
Compare
|
Build output available: |
Ruben-Lohberg
force-pushed
the
255-fix-issues-exposed-by-codechecker
branch
from
August 3, 2026 16:04
102bf62 to
376d6e2
Compare
|
Build output available: |
Ruben-Lohberg
force-pushed
the
255-fix-issues-exposed-by-codechecker
branch
from
August 3, 2026 16:10
376d6e2 to
1a71b9f
Compare
|
Build output available: |
Ruben-Lohberg
force-pushed
the
255-fix-issues-exposed-by-codechecker
branch
from
August 3, 2026 17:25
1a71b9f to
afe5f09
Compare
Ruben-Lohberg
changed the title
|
Build output available: |
Include the standard and project headers that declare functions used by each translation unit. This lets Clang analyze the files independently instead of relying on transitive includes.
Document the intended loss of precision when storing sensor and parsed values in 32-bit fields. Match variadic format arguments to the unsigned integer type expected by %X while preserving the existing lower-32-bit output.
Call std::fabs for the battery-capacity difference so overload resolution is explicit and the comparison remains in floating-point arithmetic.
The connection callback returns void, so stop processing with a plain return after a parameter-update failure instead of attempting to return the error value.
Initialize the application LED state and BMP388 FIFO sample data before they are passed to downstream code. This prevents uninitialized fields from being observed on valid error and partial-frame paths.
Only adjust and consume the FIFO length after reading it successfully. This avoids updating FIFO state or issuing a read with an undefined length after an I/O failure.
Return before selecting the Earable button when the callback does not contain its pin. This prevents dereferencing an uninitialized button pointer for an unexpected interrupt mask.
Reuse the released TX buffer when no alternative buffer is available so tx_buf cannot remain null before memset().
Validate the stereo channel count before consuming both channel pointers. If encoding fails, drop the frame instead of entering the fatal error path, log once until recovery, and never send stale encoded data.
Initialize the conditionally compiled scan parameter to NULL and describe the chip-ID copy in terms of its actual alignment and aliasing constraints.
Continue through volume and mute restoration when a codec step fails, return the first error, and only persist the requested mode after all hardware operations succeed.
Ruben-Lohberg
force-pushed
the
255-fix-issues-exposed-by-codechecker
branch
from
August 3, 2026 17:35
afe5f09 to
dcd8df4
Compare
|
Build output available: |
Ruben-Lohberg
marked this pull request as ready for review
August 3, 2026 17:46
Ruben-Lohberg
marked this pull request as draft
August 7, 2026 15:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issues exposed by CodeChecker workflow
Some CodeChecker findings were intentionally silenced while preserving existing behavior instead of redesigning the underlying error handling. For example, several ignored driver return values were made explicit with
(void)casts.Possible follow-up issues:
(void).bmp3_init()failures and ensure FIFO pressure compensation only uses valid temperature data.