Show elapsed time in recording capsule#430
Open
Michealmyson wants to merge 1 commit into
Open
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
This is a smaller follow-up to #406, adjusted to match the current typeless capsule processing logic.
Changes:
00:08.recording/transcribing/polishingcapsule states unchanged.Why
The previous PR added an explicit
insertingcapsule state, but the latest upstream capsule implementation now favors typeless processing with the existing thinking/insertion flow. This PR keeps that architecture intact and focuses only on the visible user feedback gap during recording.Verification
npm run buildsuccessfully.PR Type
Enhancement
Description
Show recording elapsed time
Track
elapsedMsin capsule UIClarify inserted count wording
Localize capsule progress strings
Diagram Walkthrough
File Walkthrough
Capsule.tsx
Render elapsed time in recording stateopenless-all/app/src/components/Capsule.tsx
formatElapsed()to format recording time asmm:ss.elapsedMsfrom incomingcapsule:stateevents.elapsedMsintoPillfor state-specific display.en.ts
Update English capsule copyopenless-all/app/src/i18n/en.ts
capsule.recordingElapsedfor the recording timer label.Inserted {{count}} chars.ja.ts
Add Japanese recording timer labelopenless-all/app/src/i18n/ja.ts
capsule.recordingElapsedfor localized elapsed-time text.ko.ts
Add Korean recording timer labelopenless-all/app/src/i18n/ko.ts
capsule.recordingElapsedfor localized elapsed-time text.zh-CN.ts
Update Simplified Chinese capsule copyopenless-all/app/src/i18n/zh-CN.ts
capsule.recordingElapsedfor the recording timer label.已插入 {{count}} 字.zh-TW.ts
Update Traditional Chinese capsule copyopenless-all/app/src/i18n/zh-TW.ts
capsule.recordingElapsedfor the recording timer label.已插入 {{count}} 字.