feat: add style pack store v1 DRAFT! 别动我PR#429
Conversation
PR Reviewer Guide 🔍(Review updated until commit c77e235)Here are some key observations to aid the review process:
|
|
先别动我的PR 别动 别动 别动,等github的review,等我自己的review,等测试 |
|
Persistent review updated to latest commit 7616ef0 |
|
Persistent review updated to latest commit c77d9f4 |
|
Persistent review updated to latest commit 0a19ad3 |
|
Persistent review updated to latest commit 0c6cc8b |
|
Persistent review updated to latest commit 16dd99c |
|
补充一轮 review fix:
本地验证:
|
|
Persistent review updated to latest commit a4c4cc2 |
|
Persistent review updated to latest commit ae2c7e4 |
|
Persistent review updated to latest commit c77e235 |
Final merge-ready review summary这一轮我按 复核范围
过程中的关键问题与修复1. 导出未保存 draft 时导出的是旧持久化内容
2. tray / 热键切换 style 后 UI 与 prefs 不同步
3. builtin style pack 保存/重置后,store 与 prefs 兼容字段可能重新分叉
本地验证结果
CI 结果当前 PR head 已更新为
最终结论这一轮复核里发现过真实阻塞项,但都已经用最小必要改动修复并完成本地回归 + CI 回归。以当前 PR head 来看,我这边的结论是:已达到 merge-ready,可继续正常评审/合并。 唯一保留说明:主 crate 的 |
User description
Summary
betasettings structure so the feature lands cleanly on the active development baseVerification
npm run buildcargo check --manifest-path src-tauri/Cargo.tomlnpx tsx src/lib/stylePrefs.test.tsPR Type
Enhancement, Bug fix, Tests
Description
Add persistent style pack storage
Route polishing through active packs
Sync prefs, tray, and exports
Move prompt editing into styles
Diagram Walkthrough
File Walkthrough
11 files
Add style pack persistence and import-exportDefine style pack and prompt modelsAssemble prompts from style pack contentExpose style pack management commandsWire coordinator into style pack runtimeRegister style pack commands and trayPass style prompts into Gemini requestsMove prompt editing guidance into settingsRebuild style pack management screenAdd IPC bindings for style packsAdd frontend style pack types2 files
Switch dictation to active style packsFix button cursor affordance2 files
Add backend prompt stubs for testsCover style preference sync behavior5 files
Localize new style prompt settings copyLocalize new style prompt settings copyLocalize new style prompt settings copyLocalize new style prompt settings copyAdd English copy for style prompts