Skip to content

Adding initial template for KNN question - #514

Merged
moe18 merged 4 commits into
Open-Deep-ML:mainfrom
kartik-git:add-knn-questions
Sep 3, 2025
Merged

moe18 merged 4 commits into
Open-Deep-ML:mainfrom
kartik-git:add-knn-questions

Conversation

@kartik-git

Copy link
Copy Markdown
Contributor

Pull request to add new KNN question

@moe18 moe18 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had one comment on the learn section

Comment thread questions/162_implement-k-nearest-neighbors/learn.md Outdated
@kartik-git

Copy link
Copy Markdown
Contributor Author

@moe18 Just edited the file. Let me know if it's good to go

@kartik-git

Copy link
Copy Markdown
Contributor Author

Hi @moe18 Just popping this back up!

@moe18 moe18 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good make it question 173

@moe18

moe18 commented Aug 19, 2025

Copy link
Copy Markdown
Collaborator

@kartik-git just wanted to follow up

@kartik-git

Copy link
Copy Markdown
Contributor Author

Hey! Yeah my bad was MIA for a while. Will make the change

@moe18

moe18 commented Aug 29, 2025

Copy link
Copy Markdown
Collaborator

just make this question 173 and I will merge it to main

@kartik-git

Copy link
Copy Markdown
Contributor Author

@moe18 Yup, made the question number change

@moe18
moe18 merged commit 08a039f into Open-Deep-ML:main Sep 3, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants