Skip to content

Fixed issue #28 - makes sure that base query is fully expanded even when it uses template parameters #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bertrandgorge wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed issue #28 - makes sure that base query is fully expanded even when it uses template parameters #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/SearchEngineConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,9 @@ public static function newFromParameters( Parser $parser, PPFrame $frame, array
// This is a "facet property", since its key is not a valid search parameter
$facet_properties[] = $parameter_value;
} elseif ( $key === "base query" ) {
// The "base query" needs special handling, because it may contain wikitext that should only be parsed
// when the search is loaded.
$expanded_value = $frame->expand( $parameter, PPFrame::RECOVER_ORIG );
// The "base query" is fully expanded at config-store time so that template arguments
// (e.g. {{{Query|default}}}) are resolved to their actual passed values.
$expanded_value = $frame->expand( $parameter );
$search_parameters["base query"] = explode( '=', $expanded_value, 2 )[1] ?? '';
} else {
// This is a "search term parameter"
Expand Down