fix: stabilize Electron BLE discovery and Android pairing - #925
Conversation
|
@codex review |
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
Security findingsAdvisory findings (1)ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 962db9ecea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Security Review
Here are some automated security review suggestions for this pull request.
Reviewed commit: 962db9ecea
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
Electron BLE polling could drop wallets between scan windows. Retain discoveries across polling windows, while refreshing disconnected peripherals through the existing cold-connection path before reconnecting. Active connections remain reusable, and Protocol V2 probe timeouts remain distinct from stale pairing errors.
Restore Android bonding before GATT setup and make the pending bond wait cancellable during transport shutdown. Stopping now removes the bond listener and deadline without waiting up to 60 seconds. Keep failure reasons separate: missing native reasons are
unknown, while SDK pairing deadlines are timeouts without automatic retry.Publish SDK packages as
1.2.2-alpha.109on npmnext. Keep@onekeyfe/react-native-ble-utilspinned to0.1.6.Validation:
yarn agent:check --profile commitpassed affected package tests and builds.yarn agent:check --profile prpassed on Node 22: version alignment, full lint, tests in 20 packages, and builds in 33 packages.nexttag. React Native and Electron tarball integrity and compiled fixes were verified.