[wpmlpb-878] Stop managing the WPBakery custom CSS fields - #561
Merged
Conversation
WPML copies `_wpb_shortcodes_custom_css` to every translation, but a page translated with the native editor has to keep its own CSS, so the WPML Page Builders integration has been overriding this to "copy once" in memory on every request since 2022 — the change these files were always meant to carry. Re-asserting that preference per request is what makes WPML compose the whole custom-field preference map on WPBakery sites (wpmldev-7467). Declaring the fields as ignored removes the conflict at the source: the integration owns the copy for both flows — refreshing a translation-editor translation on every save, and giving a natively translated page one copy that it keeps afterwards. `_wpb_post_custom_css` is added because the integration handles it the same way and it was never declared here. This has to reach live sites before WPML Page Builders 3.0 ships. The current builds are unaffected: their in-memory override still wins. https://onthegosystems.myjetbrains.com/youtrack/issue/wpmlpb-878/ Co-authored-by: Chai <david.gw@onthegosystems.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WPML integration will handle it directly.
https://onthegosystems.myjetbrains.com/youtrack/issue/wpmlpb-878/