[compdev-1364] Make a false value actually false - #547
Merged
Conversation
dgwatkins
marked this pull request as draft
July 22, 2026 16:34
dgwatkins
force-pushed
the
chai/compdev-1364
branch
from
August 4, 2026 10:26
5514516 to
a409582
Compare
dgwatkins
marked this pull request as ready for review
August 4, 2026 10:27
…y false
The attribute was cast with (bool), so the documented "false" value was
silently truthy and the only working way to disable overriding was to
omit the attribute. Parse "true" strictly, reject any value other than
"true"/"false" at build time, and report validation failures on STDERR
with a non-zero exit code so CI fails (die("message") exits 0, so the
existing path validation was never enforced either).
The 11 existing override_local="false" entries are normalized to "true"
to preserve their current effective behavior: the regenerated JSON is
identical to the one master produces. Product owners can now make each
of them a real "false" intentionally.
https://onthegosystems.myjetbrains.com/youtrack/issue/compdev-1364
Co-authored-by: Chai <david.g@onthegosystems.com>
dgwatkins
force-pushed
the
chai/compdev-1364
branch
from
August 4, 2026 10:29
a409582 to
47325bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attribute was cast with (bool), so the documented "false" value was silently truthy and the only working way to disable overriding was to omit the attribute. Parse "true" strictly, reject any value other than "true"/"false" at build time, and report validation failures on STDERR with a non-zero exit code so CI fails (die exits with 0).
https://onthegosystems.myjetbrains.com/youtrack/issue/compdev-1364