Vendor ptc-cli 1.0.4 - #12
Merged
Merged
Conversation
1.0.3 printed a GitLab recipe whose first run opened no merge request: it checked `git diff --quiet` before staging, and a plain `git diff` looks only at tracked files - on a first run the translations are new files, so the check reported "nothing changed", the push was skipped, and the job went green having produced nothing. 1.0.4 stages first and asks the index. That recipe is printed from inside this action whenever it runs `ptc init`, so the fix only reaches users through this vendoring. The same shape lives in the GitLab component template, which is not fixed here. Also arriving with 1.0.4, since 1.0.3: the rate limit is waited out rather than failing the file, and test suites for rate limiting, git context and the config examples. Pins updated with it - the component template's cli-ref and cli-sha256, and PINNED_CLI_VERSION in the self-test. The checksum was verified against what GitHub actually serves at that commit. The README carried the old shape of the GitLab recipe, which nothing printed; it now matches. Its `jq` remark is true again: the vendored copy no longer names jq on the apk line. The fixture's drift guard was skipping itself - it looked for "ptc-cli 1.0.3" while the mock says "ptc-cli.sh 1.0.3", so an empty version compared equal to nothing and passed. It now refuses to run when it cannot read the version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.0.3 printed a GitLab recipe whose first run opened no merge request. It checked
git diff --quietbefore staging, andgit difflooks only at tracked files — on a first run the translations are new files, so the check reported "nothing changed", the push was skipped, and the job went green having produced nothing. Reproduced:That recipe is printed from inside this action whenever it runs
ptc init, so the upstream fix only reaches users through this vendoring.Also arriving with 1.0.4, since 1.0.3: the rate limit is waited out rather than failing the file, plus test suites for rate limiting, git context and the config examples.
Pins
cli-refandcli-sha256in the component template, andPINNED_CLI_VERSIONin the self-test. The checksum was verified against what GitHub actually serves at that commit —curlof the pinned ref is byte-identical to the vendored file.README
It carried the old shape of the GitLab recipe, which nothing printed — neither the action nor a fresh CLI install. It now matches what
ptc initemits. Itsjqremark is true again: the vendored copy no longer names jq on the apk line.Fixture
The drift guard was skipping itself: it looked for
ptc-cli 1.0.3while the mock's docstring saysptc-cli.sh 1.0.3, so the version came out empty and the comparison passed. It now refuses to run when it cannot read the version — confirmed by pointing it at a mock claiming 1.0.1.Not fixed here
The GitLab component template still has the same first-run defect and still commits the whole workspace with
git add -A. Tracked separately.Verification
19 unit cases, 5 act jobs, shellcheck clean.