The GitLab recipe installed jq and did not name unzip - #10
Merged
Conversation
Same defect ci18-7398 found in ptc-cli, in the two copies of the recipe this repository hands out. jq appears nowhere in ptc-cli.sh. unzip is what unpacks every download. Checked against alpine:3.22: unzip is present as a busybox applet and extraction works, so nothing was broken — but the line should name what the job actually depends on, so swapping the image cannot quietly break it. git stays: the push step at the end of the job needs it, the CLI does not. The vendored ptc-cli.sh still prints the old list from its own copy of the generator; that is fixed upstream in ptc-cli main and arrives here with the next vendoring, which is a release, not a docs change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
pavel-te
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same dependency line in the two copies this repository hands out:
README.mdandtemplates/translate/template.yml.jqappears nowhere in the CLI — it was never invoked.unzipunpacks every download and was not named.Checked against
alpine:3.22:unzipis present as a busybox applet and extraction works, so the job ran either way. The line should still name what the job depends on, so that swapping the image cannot quietly break it.gitstays — the push step needs it; the CLI's own git calls are all guarded and fall back.The vendored copy of the CLI still prints the old list from its own generator. That is fixed upstream and arrives here with the next vendoring, which is a release rather than a documentation change.
Verified:
action.ymland the template parse, every yaml block in the README parses, and the component-address check still passes.